Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal refactor #547

Merged
merged 15 commits into from
Jun 23, 2024
Merged

Internal refactor #547

merged 15 commits into from
Jun 23, 2024

Conversation

Nukesor
Copy link
Owner

@Nukesor Nukesor commented Jun 23, 2024

Part of #540
Fixes #548

This MR completely restructures the daemon's architecture and process related state handling.

The code is a lot cleaner and the MPSC between the message handlers and the task handler has been removed, effectively removing a lot of potential for deadlocks and moving a lot of task related logic closer to the message handler.

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 74.41558% with 197 lines in your changes missing coverage. Please review.

Project coverage is 80.09%. Comparing base (a97448d) to head (0d9d5e3).

Files Patch % Lines
pueue/src/daemon/callbacks.rs 11.49% 77 Missing ⚠️
pueue/src/daemon/task_handler.rs 74.57% 30 Missing ⚠️
pueue/src/daemon/process_handler/finish.rs 73.62% 24 Missing ⚠️
pueue/src/daemon/process_handler/spawn.rs 88.27% 17 Missing ⚠️
pueue/src/daemon/process_handler/kill.rs 79.41% 14 Missing ⚠️
pueue/src/daemon/network/message_handler/send.rs 0.00% 10 Missing ⚠️
pueue/src/daemon/process_handler/start.rs 88.46% 6 Missing ⚠️
pueue/src/daemon/network/message_handler/group.rs 82.75% 5 Missing ⚠️
pueue/src/daemon/network/message_handler/kill.rs 62.50% 3 Missing ⚠️
pueue/src/daemon/network/message_handler/mod.rs 84.21% 3 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
- Coverage   80.25%   80.09%   -0.16%     
==========================================
  Files          77       75       -2     
  Lines        5666     5536     -130     
==========================================
- Hits         4547     4434     -113     
+ Misses       1119     1102      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 23, 2024

Test Results

  3 files  ±0   22 suites  ±0   3m 0s ⏱️ +8s
148 tests ±0  148 ✅ ±0  0 💤 ±0  0 ❌ ±0 
316 runs  ±0  316 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0d9d5e3. ± Comparison against base commit a97448d.

♻️ This comment has been updated with latest results.

@Nukesor Nukesor force-pushed the internal-refactor branch from 4fe6c23 to 3324e48 Compare June 23, 2024 11:55
@Nukesor Nukesor mentioned this pull request Jun 23, 2024
@Nukesor Nukesor merged commit a9ed6f7 into main Jun 23, 2024
18 of 19 checks passed
@Nukesor Nukesor deleted the internal-refactor branch June 23, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Process State handling
1 participant