-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support command filter on pueue status
#560
Conversation
example: pueue add -- ls /var pueue status command%=ls pueue status command=ls /var pueue status command!=ls
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #560 +/- ##
==========================================
+ Coverage 79.27% 79.34% +0.07%
==========================================
Files 75 75
Lines 5664 5690 +26
==========================================
+ Hits 4490 4515 +25
- Misses 1174 1175 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few change requests :)
Thanks! All review fixed! |
Perfect, looks good to me :) |
impl #524
example:
I'm not sure if spaces require special handling. In the above example, the query statement seems works fine even without escaping.
Also, I would like to discuss that other than the existing OPs (eq:
=
neq:!=
contains:%=
), should we further implement the semantics ofnot contain
?Thanks!
Checklist
Please make sure the PR adheres to this project's standards:
CHANGELOG.md
.cargo clippy
andcargo fmt
. The CI will fail otherwise anyway.