Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(edit): New way to edit tasks #582

Merged
merged 1 commit into from
Dec 1, 2024
Merged

change(edit): New way to edit tasks #582

merged 1 commit into from
Dec 1, 2024

Conversation

Nukesor
Copy link
Owner

@Nukesor Nukesor commented Dec 1, 2024

Implements #553

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 86.91983% with 31 lines in your changes missing coverage. Please review.

Project coverage is 78.18%. Comparing base (9a402d5) to head (1cb7d5a).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pueue/src/client/commands/edit.rs 88.98% 13 Missing ⚠️
pueue/src/daemon/network/message_handler/edit.rs 77.19% 13 Missing ⚠️
pueue/src/daemon/callbacks.rs 0.00% 2 Missing ⚠️
pueue/src/daemon/network/message_handler/stash.rs 0.00% 2 Missing ⚠️
pueue/src/bin/pueued.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
- Coverage   78.25%   78.18%   -0.07%     
==========================================
  Files          74       73       -1     
  Lines        5899     5913      +14     
==========================================
+ Hits         4616     4623       +7     
- Misses       1283     1290       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This change introduces a completely new way to edit tasks and allows to
edit multiple tasks in one go.

This is effectively a breaking change in all regards, since the API and
the CLI changed due to this.
Copy link

github-actions bot commented Dec 1, 2024

Test Results

  3 files  ±0   19 suites  ±0   3m 7s ⏱️ -1s
161 tests ±0  161 ✅ ±0  0 💤 ±0  0 ❌ ±0 
340 runs  ±0  340 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1cb7d5a. ± Comparison against base commit 5738fc9.

@Nukesor Nukesor merged commit d43beef into main Dec 1, 2024
19 checks passed
@Nukesor Nukesor deleted the edit-tasks branch December 1, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant