Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow scope, specify route generation #7

Closed
wants to merge 2 commits into from
Closed

Narrow scope, specify route generation #7

wants to merge 2 commits into from

Conversation

michaelrkn
Copy link

This PR addresses the comments I raised. I hope it's helpful!

This RFC shouldn't be blocked by other RFCs that are complementary but not dependent.
@NullVoxPopuli
Copy link
Owner

Thanks for this!

can you change the target to NullVoxPopuli:controller-migration-path instead of master?

Thanks!!!!!

@michaelrkn michaelrkn changed the base branch from master to controller-migration-path June 28, 2019 19:33
@michaelrkn
Copy link
Author

Done!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants