Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duplicate code for server.py and adapt config parameter #4

Merged
merged 4 commits into from
Dec 24, 2022
Merged

remove duplicate code for server.py and adapt config parameter #4

merged 4 commits into from
Dec 24, 2022

Conversation

danielnugraha
Copy link
Collaborator

Changelog:

  1. Most of the code in server.py is duplicate to flwr source code. It is now deleted.
  2. ServerConfig Parameter is also adapted according to Flower 1.0.

NumericalMax
NumericalMax approved these changes Dec 23, 2022
View reviewed changes
examples/ios/README.md

## Project Setup

Requirements for setting up a server:

- Conda for managing environment
- Python3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could specify the minimum Python version required, e.g, Python 3.7.

@weinhuber
Copy link
Collaborator

weinhuber commented Dec 23, 2022 •
edited
Loading

Just out of curiosity:
Is the server.py now backward compatible too?
Do we support flwr version 1.1 too or just 1.0?

maybe we could mention that in the readme

@NumericalMax NumericalMax merged commit d1df680 into main Dec 24, 2022
@NumericalMax NumericalMax deleted the adapt-server.py branch December 24, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weinhuber weinhuber weinhuber approved these changes

@NumericalMax NumericalMax NumericalMax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielnugraha @weinhuber @NumericalMax