Add flwr proto status #7
Conversation
There was a problem hiding this comment.
The translation from struct Code to Flwr_Proto_Code e.g. in propertiesToProto, fitResToProto, evaluateResToProto, parametersToProto, should be implemented in Serde.swift.
Naming changes in Typing.swift and Serde.swift, analog to changes in transport.pb file: e.g Properties and 'PropertiesRes' to GetPropertiesIns and GetPropertiesRes, Parameters and 'ParametersRes' to GetParametersIns and GetParametersRes.
The Client protocol extension should be modified, since we are not using getProperties right now, it should contain an getPropertiesNotImplemented code in its returned object. Optional message in string would be "Client does not implement get_properties"
Status Code ok with optional message "Success" should be implemented in the example project.
|
|
||
| public init(parameters: Parameters) { | ||
| self.parameters = parameters | ||
| self.status = Status(code: .ok, message: String()) |
There was a problem hiding this comment.
The status should be left as a parameter
public init(status: Status, parameters: Parameters)
|
|
||
| public init(parameters: Parameters, numExamples: Int, metrics: Metrics? = nil) { | ||
| self.parameters = parameters | ||
| self.numExamples = numExamples | ||
| self.metrics = metrics | ||
| self.status = Status(code: .ok, message: String()) |
There was a problem hiding this comment.
The status should be left as a parameter
public init(status: Status, parameters: Parameters, numExamples: Int, metrics: Metrics? = nil)
Protobuf to own struct and vice versa
According to the
transport.pbtemplate theStatusstruct was added to the code.