feat: add maximum length flag (#91) #120
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding the length flag in reference to #91.
i assumed the default value of the maximum length according to the 50/72 rule, but of course this is still an opinionated change and should be discussed according to what you guys think!
i still have an issue though with
commands/prepare-commits-msg-hook.ts
, should it:cli.ts
togenerateCommitMessage
,generateCommitMessage
invocation,process.argv.slice line
? (probably bad for maintainability)thx for reading!