-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
actions: reinstate validation of schemas and examples, fixes #1739 #1911
Conversation
@kylef for visibility I've copied your comment here from #1730 as that PR is merged and added the TODO items as I see them now to the initial comment. |
Thanks @MikeRalphson. I'd add one more point to the TODO tasks above, once released we should signal in NPM that the existing swagger-schema-official package is deprecated, this can be done with the I can provide some input on some of the questions above:
I can confirm the
For consistency with GitHub, perhaps creating an The prior specifictions package was released under the
Since there is a TODO for |
4787ae6
to
45a5c78
Compare
45a5c78
to
247ea41
Compare
Action: @MikeRalphson to update package versions. |
This PR is now out of date and does not fit with newer schema test workflows or the version requirements of our node environment, and the original submitter is not currently available to rework it. I have filed issue #3557 to track replacing this PR with a modernized update so we can close out this PR. |
As promised, following the merging of #1270 / #1897
Note: items related to publishing an npm package containing the schemas will be moved to a new issue.
This PR now reinstates the validation of examples and schemas using GitHub Actions.