Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JSON Schema Draft to 2020-12 and make $ref resolution rules explicit #2437

Merged
merged 15 commits into from
Jan 21, 2021
Merged

Update JSON Schema Draft to 2020-12 and make $ref resolution rules explicit #2437

merged 15 commits into from
Jan 21, 2021

Commits on Jan 8, 2021

  1. fix http link to json-schema.org 

    Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
    @MikeRalphson
    MikeRalphson committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    9418bab View commit details
    Browse the repository at this point in the history

  2. fix http link to spec.commonmark.org 

    Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
    @MikeRalphson
    MikeRalphson committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    b401f9d View commit details
    Browse the repository at this point in the history

  3. Specify rules for $ref resolution 

    Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
    @MikeRalphson
    MikeRalphson committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    01a1d5b View commit details
    Browse the repository at this point in the history

  4. Specify relative resolution rules for pathItem $ref and example exter… 

    …nalValue

Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
    @MikeRalphson
    MikeRalphson committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    f6cb933 View commit details
    Browse the repository at this point in the history

  5. Update JSON Schema draft links to 2020-12 IETF pages 

    Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
    @MikeRalphson
    MikeRalphson committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    27e28e8 View commit details
    Browse the repository at this point in the history

  6. Make language about 'MUST be in the form of a ...' consistent 

    Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
    @MikeRalphson
    MikeRalphson committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    d6b173e View commit details
    Browse the repository at this point in the history

  7. Make it clear pathItem $refs don't need to be external now 

    Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
    @MikeRalphson
    MikeRalphson committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    eeab8ec View commit details
    Browse the repository at this point in the history

  8. Make RFC links consistent with regard to spacing 

    Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
    @MikeRalphson
    MikeRalphson committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    b814de4 View commit details
    Browse the repository at this point in the history

  9. Allow a URI for example.externalValue fields 

    This makes it fall under the rules for relative references.

Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
    @MikeRalphson
    MikeRalphson committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    8fc2623 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2021

  1. Explicitly call out $ref as a Relative Reference

    @MikeRalphson
    MikeRalphson committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    52d5aab View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. Remove wording about what implementations SHOULD/MAY do with a $ref

    @MikeRalphson
    MikeRalphson committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    4e7a1d1 View commit details
    Browse the repository at this point in the history

  2. Prefer 'referenced document' to 'referrant document' for clarity

    @MikeRalphson
    MikeRalphson committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    8caec42 View commit details
    Browse the repository at this point in the history

  3. Fix JSON Schema $ref resolution fallback rule

    @MikeRalphson
    MikeRalphson committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    659c8ea View commit details
    Browse the repository at this point in the history

  4. Add links back to #relativeReferences definition

    @MikeRalphson
    MikeRalphson committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    c4d34fc View commit details
    Browse the repository at this point in the history

  5. Split #relativeReferences definition into URL and URI sections 

    Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
    @MikeRalphson
    MikeRalphson committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    d094bdf View commit details
    Browse the repository at this point in the history