Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

whitespace and quoting fixes in json and yaml examples (v3.2.0) #3466

Merged
merged 1 commit into from
Feb 22, 2024
Merged

whitespace and quoting fixes in json and yaml examples (v3.2.0) #3466

merged 1 commit into from
Feb 22, 2024

Conversation

karenetheridge
Copy link
Member

@karenetheridge karenetheridge commented Dec 6, 2023 •
edited
Loading

same as #3465

@karenetheridge karenetheridge mentioned this pull request Dec 6, 2023
Closed
SyedAmbro
SyedAmbro approved these changes Dec 6, 2023
View reviewed changes
Copy link

@SyedAmbro SyedAmbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [ ]

@karenetheridge karenetheridge changed the title whitespace and quoting fixes in json and yaml examples whitespace and quoting fixes in json and yaml examples (v3.2.0) Dec 9, 2023
CASABECI
CASABECI approved these changes Dec 21, 2023
View reviewed changes
Copy link

@CASABECI CASABECI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wkn

@karenetheridge karenetheridge force-pushed the ether/whitespace-examples-v3.2.0 branch from f75f3bd to ab71df8 Compare December 27, 2023 19:46
@karenetheridge
Copy link
Member Author

rebased.

@handrews handrews added this to the v3.2.0 milestone Jan 27, 2024
@handrews handrews added the examples requests for more or better examples in the specification label Jan 29, 2024
@handrews handrews mentioned this pull request Jan 29, 2024
Closed
@karenetheridge karenetheridge force-pushed the ether/whitespace-examples-v3.2.0 branch from ab71df8 to cad9c6d Compare February 5, 2024 06:20
@handrews
Copy link
Member

handrews commented Feb 7, 2024

I re-ran the failed check using the environment from main (see #3554) and it passed. This is safe to merge.

@handrews handrews mentioned this pull request Feb 10, 2024
Closed
@mikekistler
Copy link
Contributor

Question on this: Can we establish our conventions for whitespace and quoting and then enforce them in the PR pipeline? I'm just thinking that we don't want to have to fix this again in 6 months.

@lornajane
Copy link
Contributor

Yes, let's open an issue for it. I have this on a bunch of other repos and can add it here too

@karenetheridge karenetheridge force-pushed the ether/whitespace-examples-v3.2.0 branch from cad9c6d to 856c742 Compare February 20, 2024 01:13
@karenetheridge
Copy link
Member Author

rebased!

@karenetheridge karenetheridge force-pushed the ether/whitespace-examples-v3.2.0 branch from 856c742 to abaa97d Compare February 20, 2024 01:24
@lornajane lornajane mentioned this pull request Feb 20, 2024
Closed
@lornajane
Copy link
Contributor

I opened #3596 to make this repeatable

@karenetheridge karenetheridge mentioned this pull request Feb 21, 2024
Closed
@earth2marsh earth2marsh merged commit cd2a3a4 into OAI:v3.2.0-dev Feb 22, 2024
1 check passed
@karenetheridge karenetheridge deleted the ether/whitespace-examples-v3.2.0 branch February 22, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SyedAmbro SyedAmbro SyedAmbro approved these changes

@CASABECI CASABECI CASABECI approved these changes

@darrelmiller darrelmiller darrelmiller approved these changes

Assignees
No one assigned
Labels
examples requests for more or better examples in the specification
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
8 participants
@karenetheridge @handrews @mikekistler @lornajane @darrelmiller @CASABECI @SyedAmbro @earth2marsh