Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds missing package lock for reproductible CI #3564

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

baywet
Copy link
Contributor

@baywet baywet commented Feb 9, 2024

fixes #3556

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet requested review from a team as code owners February 9, 2024 13:01
@baywet
Copy link
Contributor Author

baywet commented Feb 9, 2024

Note: the schema test will fail until we merge to main since there currently isn't any package-lock.json on main

@lornajane
Copy link
Contributor

How does this change affect people running the checks locally?

@baywet
Copy link
Contributor Author

baywet commented Feb 9, 2024

when you install locally, you'll get the same exact versions that were installed when this file was setup (or whenever a dependabot update was merged). It improves reproducibility

@baywet
Copy link
Contributor Author

baywet commented Feb 9, 2024

on the first pull after this gets merged however, you might have git complaining that you already have a package-lock.json if you've already ran npm i. Just delete it. That's a one time problem affecting people who installed before this PR.
People familiar with git and/or npm should be able to resolve that on their own without requiring assistance.

Copy link
Member

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. You'll need to make PRs copying the schema-tests.yaml workflow out to the v3.0.4-dev, v3.1.1-dev, and v3.2.0-dev (like PRs #3560, #3561, and #3562).

@handrews
Copy link
Member

After some discussion last week, this sort of limited-impact change (most of our checks are failing right now anyway) can be merged with one approval, so I'm doing that.

@handrews handrews merged commit 617f3d9 into OAI:main Feb 13, 2024
1 of 2 checks passed
@baywet baywet deleted the bugfix/package-lock branch August 21, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

this repository should contain a package-lock.json
3 participants