Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add criteria for minor and patch releases #4184

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

lornajane
Copy link
Contributor

We had some great discussions in the TDC meetings when we were finalising what should go into the recent patch releases and what must be a minor release. This pull request takes those discussions into our CONTRIBUTING file.

Fixes #3528
Fixes #3529

@lornajane lornajane requested review from a team as code owners November 10, 2024 17:03
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, minor nits

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
mikekistler
mikekistler previously approved these changes Nov 11, 2024
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

Co-authored-by: Ralf Handl <ralf.handl@sap.com>
@ralfhandl ralfhandl requested a review from a team November 14, 2024 12:56
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving.

@ralfhandl ralfhandl merged commit 84c49a8 into OAI:main Nov 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.x minor release approach 3.x.y patch release approach
3 participants