Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] link_tracker #2274

Merged
merged 1 commit into from
Apr 12, 2020
Merged

[13.0][MIG] link_tracker #2274

merged 1 commit into from
Apr 12, 2020

Conversation

Yasaie
Copy link
Member

@Yasaie Yasaie commented Apr 7, 2020

Migration of link_tracker

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@MiquelRForgeFlow MiquelRForgeFlow added this to the 13.0 milestone Apr 7, 2020
@Yasaie
Copy link
Member Author

Yasaie commented Apr 8, 2020

@MiquelRForgeFlow Thanks for reviews. changes made

@pedrobaeza pedrobaeza mentioned this pull request Apr 11, 2020
Closed
@pedrobaeza
Copy link
Member

Hi, Payam, thanks for your contributions. OpenUpgrade migration scripts are the hardest thing to introduce in the OCA world, but it seems you are getting it.

I'm looking for the OCA CLA (https://odoo-community.org/page/cla) and I'm not able to find it. Did you send it?

@pedrobaeza
Copy link
Member

Also, for being agile, would you allow me to push to your PR branches for adding/fixing things that I find in my review?

pedrobaeza
pedrobaeza requested changes Apr 11, 2020
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do the changes if you allow me

addons/link_tracker/migrations/13.0.1.0/openupgrade_analysis_work.txt Outdated Show resolved Hide resolved
addons/link_tracker/migrations/13.0.1.0/openupgrade_analysis_work.txt Outdated Show resolved Hide resolved
addons/link_tracker/migrations/13.0.1.0/post-migration.py Show resolved Hide resolved
@Yasaie
Copy link
Member Author

Yasaie commented Apr 12, 2020

Hi @pedrobaeza

I have already sent the CLA request and I'm waiting to accept it soon.
Sure you can change as many as you can. But tell me what are they so I be more careful next time

Thank you

@Yasaie
Copy link
Member Author

Yasaie commented Apr 12, 2020

@pedrobaeza I have sent a PR http://www.odoo.com/submit-pr is this enough or I should send an email to cla AT odoo-community.org too?

@pedrobaeza
Copy link
Member

That's Odoo core CLA, for contributing to Odoo core, not OCA CLA. Please see the link I sent you. Without it, it's not possible to merge this.

@Yasaie
Copy link
Member Author

Yasaie commented Apr 12, 2020

@pedrobaeza I sent Signed of OCA CLA. would you please confirm it
Thanks

@pedrobaeza
Copy link
Member

CLA verified, thanks

@pedrobaeza pedrobaeza merged commit fa499ec into OCA:13.0 Apr 12, 2020
@Yasaie Yasaie deleted the 13.0-mig-link_tracker branch April 12, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved needs review
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Yasaie @pedrobaeza @MiquelRForgeFlow @OCA-git-bot