[13.0][MIG] account

[MiquelRForgeFlow]

Migration of account.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[gdgellatly]

ex tax invoices are showing the tax as an invoice line on historic invoices.

[MiquelRForgeFlow]

ex tax invoices are showing the tax as an invoice line on historic invoices.

yeah, and that's wrong? how should be handled correctly from your POV?

[fmdl]

@MiquelRForgeFlow can make a litlle text to explain the methodoly to merge account.move and account.invoice ? Thanks

[gdgellatly]

ex tax invoices are showing the tax as an invoice line on historic invoices.

yeah, and that's wrong? how should be handled correctly from your POV?

@MiquelRForgeFlow Sorry, I opened an issue with more detail that got closed before I added that 1 liner, which was that for this particular migration I could live with it.. Anyway, whether it is wrong or not I don't know. It certainly looks wrong, but I haven't done an actual invoice on v13 yet to know what looks right, but I imagine it should look the same as doing an invoice in v13.

[khaeusler]

I've tried to migrate a v12 demo DB with the PR. In the demo DB, I added taxes to a product, created a sales order and then created an invoice.

The result on the migrated invoice is:
Untaxed Amount: $ 14,750.00
Tax 15%: $ 0.00
Total: $ 16,962.50

Invoice in v12

Migrated invoice in v13

If the Quantity is changed, the "Tax" in the footer changes correctly, but the "Untaced amount" is incorrectly changed to 0.

[MiquelRForgeFlow]

@khaeusler thanks for your input. I will try to solve your case when having some time.

[pedrobaeza]

Commit ae60003c91c9d524404d6de7ee074986f1e2cb0e shouldn't be here.

[MiquelRForgeFlow]

Hello everybody following this PR, I have added the relation between move lines and requisition lines and account tags. Could you do one last review?

@etobella I have implemented the other way for grouped journal items. Could you check again?

@nomadic-coding could you check again if your issues persist?

[nomadic-coding]

@MiquelRForgeFlow @kos94ok-3D thanks for the fixes. Looks good now. Well done. I'll keep on testing.

[etobella]

Tested with aggregated invoices and not and all works as expected

[pedrobaeza]

OK, let's merge this as a good base and we can improve later if we find more things. Thanks to all the involved people in developing and reviewing.

[BartvandenHout]

I tried a v12 > v13 upgrade today. Seems all but account is working. I still don't get the correct invoices. On my v13-database the account_move and account_move_line I get, seems to me, incorrect or no values:

account_move
Not set correctly:
type = 'entry' on all records
Not set al all:
to_check, amount_untaxed, amount_tax, amount_residual, amount_untaxed_signed, amount_tax_signed, amount_residual_signed, fiscal_position_id, invoice_payment_state, invoice_date, invoice_date_due, invoice_payment_ref, invoice_sent, invoice_origin

account_move_line
Not set:
amount_residual, is_rounding_line, exclude_from_invoice_tab

Am I forgetting something? Is my v12-dbase not correct (seems to be, though)? Is it still work-in-progress?

FYI, to get the latest OpenUpgrade installation I installed today:
pip3 install git+git://github.com/OCA/openupgradelib.git
git clone https://github.com/OCA/OpenUpgrade.git
cd OpenUpgrade
git pull origin 13.0

Btw. Thanks for all the work you put into it

[pedrobaeza]

Sorry, but everything is working in our side, so you should have something incorrect in your end, or some non described steps to get to that problem, so unless you bring more information to shed some light, nothing can be done.

[BartvandenHout]

Thank for your reply. I tried my method with a new database, and no invoices either. So it's definitely on my side. Can you see what's wrong with my current process?

Deleted post partially: an incorrect method should not be found on the internet

Any advice would be greatly appreciated!

[pedrobaeza]

It should fall on data side, so I'm afraid I can't help you

[MiquelRForgeFlow]

@BartvandenHout maybe you will find a clue in the logs of your migration

[BartvandenHout]

Deleted post: wrong place for posting my method. I'll find a better place for it :-)