[13.0][OU-MIG] website_event #2588
Conversation
| @@ -0,0 +1,35 @@ | |||
| ---Models in module 'website_event'--- | |||
| ---Fields in module 'website_event'--- | |||
| website_event / event.event / cover_properties (text) : NEW hasdefault | |||
There was a problem hiding this comment.
Are the default cover properties the equivalent visualization to what Odoo did in v12, or you should change them to mimic the previous behavior for not having visual differences?
There was a problem hiding this comment.
I don't know.
There was a problem hiding this comment.
Then you should investigate it. If not, the PR is not complete.
There was a problem hiding this comment.
I investigated and I think it's fine as it is, nothing to do. That thing it's more like of a new feature, only used for background-images.
There was a problem hiding this comment.
Then a blog cover in v12 is seen the same in v13, no matter the properties set in v12?
There was a problem hiding this comment.
event_cover_properties = json.loads(self.cover_properties)
# background-image might contain single quotes eg `url('/my/url')`
res['default_opengraph']['og:image'] = res['default_twitter']['twitter:image'] = event_cover_properties.get('background-image', 'none')[4:-1].strip("'")that's the only use of event cover_properties, the twitter image, and in v12 I don't see that was filled, so it's pretty something new.
# NOTHING TO DO--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr