[13.0][MIG] repair

[victoralmau]

Migration to 13.0.

@Tecnativa TT27870

[MiquelRForgeFlow]

Needs post-migration file with:

    openupgrade.load_data(
        env.cr, "repair", "migrations/13.0.1.0/noupdate_changes.xml")

[victoralmau]

Thanks @pedrobaeza , changes done.

[kos94ok-3D]

I think you mistook

[kos94ok-3D]

@victoralmau I do not understand you mistook or do not understand that this commit:f380d6e is correct and this one is useless (why need to update legacy name) aff700d

[victoralmau]

@victoralmau I do not understand you mistook or do not understand that this commit:f380d6e is correct and this one is useless (why need to update legacy name) aff700d

My last changes are necessary to prevent error in github action called "Test OpenUpgrade migration / test (pull_request)"

[victoralmau]

Thanks @kos94ok-3D and @MiquelRForgeFlow changes done.

[MiquelRForgeFlow]

Poor @victoralmau 😂

[pedrobaeza]

Well, it's a mix of bad interpretations + incorrect reviews. The history is:

• Here I say to not create the columns manually and fill them on post: [13.0][MIG] repair #2721 (comment)
• But he moves entire thing, including rename_columns, to post.
• @kos94ok-3D told incorrectly to change to copy_columns.
• @MiquelRForgeFlow told to move it to pre, but not commenting about the incorrect copy.
• The correct combination is pre + rename.

So please all take more attention for not having all these rounds.

[victoralmau]

Thanks @pedrobaeza changes done.

[pedrobaeza]

Please double check changes