Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] website_google_map #3209

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

MiquelRForgeFlow
Copy link
Contributor

No description provided.

Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the migration_analysis file is absent. Could you generate it ?

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@legalsylvain is it necessary to generate the analysis for this module? There are no models or noupdate records in this module. Isn't that why the analysis was not generated in the first place?

@legalsylvain
Copy link
Contributor

Hi.

@StefanRijnhart :

My question is : why migration folder + file is not generated for website_google_map and generated for barcodes.
As the original developper of the module upgrade_analysis, do you have an idea ? (otherwise, I'll take a look ...)

In fact, it's not related to that current PR, so OK to move forward ! Sorry for having blocking this PR.

@legalsylvain legalsylvain merged commit 5809c60 into OCA:14.0 Jun 16, 2022
@legalsylvain
Copy link
Contributor

merging trivial PR. Thanks @MiquelRForgeFlow.

@MiquelRForgeFlow MiquelRForgeFlow deleted the 14.0-mig-website_google_map branch June 16, 2022 09:00
@StefanRijnhart
Copy link
Member

@legalsylvain I think this is due to an implementation detail that may have changed over time. If there are no models and no change in the set of XML records, I am not surprised that there is no analysis but I agree it would probably better if there was.

@StefanRijnhart
Copy link
Member

And thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants