Product v8 migration #37
Conversation
XML ID migration complete
…Upgrade into product-v8-migration
Now a fields.property so the prices are moved to properties. Also, entries for the prices will be created in product_price_history.
…roduct-v8-migration Conflicts: addons/product/migrations/8.0.1.1/post-migration.py
…uct have a standard price for the past, not only from now
|
Amazing work, thanks! 👍 |
|
|
||
| def copy_fields(cr, pool): | ||
| product_tmpl= pool['product.template'] | ||
| # copy the active field from product to template |
There was a problem hiding this comment.
Oh, flake8 warns about the missing space here in line 57
|
Yep, missed this one. Should be better now. |
| @@ -0,0 +1,18 @@ | |||
| from openerp.openupgrade import openupgrade | |||
There was a problem hiding this comment.
This file should be called post-migration.py
Also, there are pep8 issues in this script.
|
A few files have the wrong name. Have they been running? |
|
Everything called [pre|post]-*.py will run. Non-blocking IMHO, we can clean up and rename according to some convention later on. |
|
In that case, the .travis.yml file needs to reflect this. |
|
All is well on pep-bot after changing the file pattern 👍 |
[ADD] Product v8 migration
| from openerp.openupgrade import openupgrade | ||
| from openerp import pooler, SUPERUSER_ID | ||
|
|
||
| def move_fields(cr, pool): |
There was a problem hiding this comment.
This function is incomplete:
- not closed bracket
- unused variables
|
@komsas the CI actually returned a green result because it was not considering a file in mrp, that's why I didn't caught the issues. This is the only file having issues, I will make a new PR (note that mrp still needs to be migrated). |
Migrate products!