Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [OU-ADD] mail #3832

Merged
merged 1 commit into from
Jun 8, 2023
Merged

[16.0] [OU-ADD] mail #3832

merged 1 commit into from
Jun 8, 2023

Conversation

marielejeune
Copy link
Contributor

@marielejeune marielejeune commented Apr 25, 2023 •
edited
Loading

Significant changes:

  • Model mail.channel.partner renamed to mail.channel.member
  • Field scheduled_date on mail.mail is now datetime (not char anymore)

@legalsylvain legalsylvain added this to the 16.0 milestone May 1, 2023
@marielejeune marielejeune marked this pull request as draft May 2, 2023 07:24
@marielejeune marielejeune force-pushed the 16.0-mail-mle branch 2 times, most recently from 19043f8 to a4cbabb Compare May 2, 2023 08:47
@marielejeune marielejeune marked this pull request as ready for review May 2, 2023 08:53
legalsylvain
legalsylvain reviewed May 2, 2023
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except my two remarks. LGTM. Thanks !

@pedrobaeza pedrobaeza mentioned this pull request May 16, 2023
Closed
@remytms
Copy link
Contributor

remytms commented May 17, 2023

@legalsylvain or @pedrobaeza Can you reference this PR in the Migration to 16.0 issue with /ocabot migration mail ? :)

@pedrobaeza
Copy link
Member

/ocabot migration mail

@OCA-git-bot
Copy link
Contributor

Sorry @remytms you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@OCA-git-bot OCA-git-bot mentioned this pull request May 17, 2023
Open
@marielejeune marielejeune force-pushed the 16.0-mail-mle branch 2 times, most recently from d62d1d2 to e9b11e8 Compare June 6, 2023 08:42
@marielejeune marielejeune force-pushed the 16.0-mail-mle branch 2 times, most recently from eb2442f to ab93c7f Compare June 7, 2023 09:22
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza merged commit 37494be into OCA:16.0 Jun 8, 2023
cvinh
cvinh reviewed Aug 18, 2023
View reviewed changes
openupgrade_scripts/scripts/mail/16.0.1.10/upgrade_analysis_work.txt
---Models in module 'mail'---
obsolete model mail.channel.partner
obsolete model mail.resend.cancel [transient]
model fetchmail.server (moved from fetchmail)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marielejeune is there any specific reason why I don't see _models_renames for fetchmail model ? Thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I understood, the model has been 'moved' and not 'renamed'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remytms remytms remytms left review comments

@cvinh cvinh cvinh left review comments

@legalsylvain legalsylvain legalsylvain left review comments

@hbrunn hbrunn hbrunn approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
8 participants
@marielejeune @remytms @pedrobaeza @OCA-git-bot @hbrunn @legalsylvain @cvinh @MiquelRForgeFlow