[16.0][OU-ADD] hr_contract #3912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the changes are managed by the migration script of hr module. Load the noupdate_changes file.
|
/ocabot migration hr_contract |
nguyenvietlam0640
approved these changes
Jun 28, 2023
|
This PR has the |
This was referenced Oct 20, 2023
victoralmau
approved these changes
Oct 23, 2023
|
merge? |
|
I think that it will be merge when dependencies will be scripted and merged. |
|
@legalsylvain I think this is not blocked by dependency anymore, since the merge of module |
pedrobaeza
requested changes
Feb 24, 2024
|
|
||
| @openupgrade.migrate() | ||
| def migrate(env, version): | ||
| openupgrade.load_data(env.cr, "hr_contract", "16.0.1.0/noupdate_changes.xml") |
There was a problem hiding this comment.
Analyzing noupdate_changes.xml file, the group_hr_contract_manager is being modified through (4, id), which means that the previous content is kept, and we don't want this, so you should add first a (5, ) command for erasing current content.
|
Superseded by #4336 for adding the missing piece. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes are managed by the migration script of hr module. Load the noupdate_changes file.