Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Analysis #399

Merged
merged 1 commit into from
Nov 17, 2015
Merged

[ADD] Analysis #399

merged 1 commit into from
Nov 17, 2015

Conversation

StefanRijnhart
Copy link
Member

No description provided.

@StefanRijnhart StefanRijnhart mentioned this pull request Nov 17, 2015
@StefanRijnhart
Copy link
Member Author

Note that because the diff is too long, the Files Changed tab in this PR is slightly misleading. At some point, GitHub will not show the contents of newly added files anymore, saying that they 'have not changed'.

@dreispt
Copy link
Member

dreispt commented Nov 17, 2015

👍

1 similar comment
@parthivgls
Copy link

👍

@pedrobaeza
Copy link
Member

Only one question: do you think it deserves to be included the l10n_* analysis file?

@StefanRijnhart
Copy link
Member Author

Yes, certainly. The l10n analysis files are only interesting in very few corner cases, but it doesn't really hurt to include them now, even if they make the diff of this particular PR very long. It would be more of a pain for the odd l10n developer to have to generate the analysis themselves in case they need it. Also for the regular OpenUpgrade migration script submission process it is essential to be able to check easily if an l10n module does not unexpectedly contains any noupdate data that has to be taken care of.

@pedrobaeza
Copy link
Member

OK, you're right. Thanks for the huge work you always do in this project when a new version comes. I merge this PR for allowing to start the migration scripts. For those who wants to contribute in this part, please comment on #400 for avoiding the duplication of efforts.

pedrobaeza added a commit that referenced this pull request Nov 17, 2015
@pedrobaeza pedrobaeza merged commit b0ba221 into OCA:9.0 Nov 17, 2015
@StefanRijnhart StefanRijnhart deleted the 9.0-analysis branch November 16, 2017 08:23
diamondnguyenkc pushed a commit to diamondnguyenkc/OpenUpgrade that referenced this pull request Jul 13, 2023
* [MISC] apriori: add section for Viindoo

* [MISC] apriori: add project section for Viindoo

---------

Co-authored-by: Tran Truong Son <truongson290893@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants