[FIX] patch tables for setup_models() #405
Conversation
|
Seems OK and can be run multiple times without breaking, so 👍 |
|
isn't this too late? Why not in |
|
It crashes on cr.execute('select model, transient from ir_model where state=%s', ('manual',)), 3 lines below. But yes, it could be moved right after the has_unaccent bit. Should I? Done. @hbrunn is this better? |
|
👍 |
| @@ -65,6 +65,9 @@ def __init__(self, db_name): | |||
| if openerp.tools.config['unaccent'] and not has_unaccent: | |||
| _logger.warning("The option --unaccent was given but no unaccent() function was found in database.") | |||
| self.has_unaccent = openerp.tools.config['unaccent'] and has_unaccent | |||
|
|
|||
| # ir_model must be in 9.0 format before continuing | |||
There was a problem hiding this comment.
Can you add a marker #OpenUpgrade to this change?
|
Thanks, looks good! Just a request to isolate the code into the OpenUpgrade corner as much as possible. |
|
Thanks for the update. Next time, please write a comment that you followed up the comments, so that the reviewers get notified by email. |
[FIX] patch tables for setup_models()
|
Fixed trivial flake8 issue in direct commit cbced54 |
|
I will, and thanks for the whitespace! |
|
@StefanRijnhart , I missed something and had to resubmit as #410 |
Odoo does not boot unless some tables are manually updated on the migrated database. As discussed in #404 .