Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][OU-IMP] web: Auto-define company fields used in reports (report_footer + company_details) #4095

Merged
merged 1 commit into from
Nov 15, 2024
Merged

[15.0][OU-IMP] web: Auto-define company fields used in reports (report_footer + company_details) #4095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions openupgrade_scripts/scripts/web/15.0.1.0/post-migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# Copyright 2023-2024 Tecnativa - Víctor Martínez
from openupgradelib import openupgrade


@openupgrade.migrate()
def migrate(env, version):
"""It is important to set the appropriate report_footer and company_details values.
The report_footer field already existed before, but it only represented the 'extra'
text that was added after the company data (https://github.com/odoo/odoo/blob/cc0060e889603eb2e47fa44a8a22a70d7d784185/addons/web/views/report_templates.xml#L367).
Now in v15 this data https://github.com/odoo/odoo/blob/3a28e5b0adbb36bdb1155a6854cdfbe4e7f9b187/addons/web/views/report_templates.xml#L338
is not shown unless it is defined; therefore, we must apply the corresponding
default that would be defined from the base.document.layout wizard and then add the
old report_footer data (if it was defined).
There is now a company_details field that does not have a default value, so it will
be created empty.
It is important to define the corresponding value that would be defined from the
base.document.layout wizard because in the report now only the content of that
field is shown, while in v14 it was not necessary since the address was shown
according to the partner_id field.
v14 https://github.com/odoo/odoo/blob/cc0060e889603eb2e47fa44a8a22a70d7d784185/addons/web/views/report_templates.xml#L343
vs v15 https://github.com/odoo/odoo/blob/3a28e5b0adbb36bdb1155a6854cdfbe4e7f9b187/addons/web/views/report_templates.xml#L319
""" # noqa: B950
for company in env["res.company"].search([]):
wizard = env["base.document.layout"].with_company(company).create({})
report_footer = wizard.report_footer
if company.report_footer:
report_footer += company.report_footer
company.write(
{
"report_footer": report_footer,
"company_details": wizard.company_details,
}
)
Loading