Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][OU-ADD] payment_stripe: Migration to 16.0 #4178

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Oct 20, 2023

Migration to 16.0

Depends on:

@Tecnativa TT45236

@legalsylvain
Copy link
Contributor

legalsylvain commented Oct 20, 2023

/ocabot migration payment_stripe

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd comment in the /noupdate_changes.xml file these fields, which don't change from version to version:

    <field name="allow_tokenization">True</field>
    <field name="code">stripe</field>

@victoralmau
Copy link
Member Author

I'd comment in the /noupdate_changes.xml file these fields, which don't change from version to version:

    <field name="allow_tokenization">True</field>
    <field name="code">stripe</field>

In another PR it was discussed about commenting on the noupdate_changes.xml file but it was concluded not to do so because the content of the file is generated "automatically" and I would suggest again to uncomment it.

Although I agree that it is not necessary to update those fields, I think it does not bother either, and it is useful to use the noupdate_changes.xml file (if it exists) in the migration in case new changes are added there in the future.

@pedrobaeza
Copy link
Member

The problem is to remove the lines, not to comment them.

@victoralmau victoralmau force-pushed the 16.0-mig-payment_stripe branch from 287ca76 to 9650ee2 Compare October 20, 2023 11:43
@victoralmau victoralmau force-pushed the 16.0-mig-payment_stripe branch from 8f5e9a6 to b109c13 Compare November 28, 2023 12:21
@pedrobaeza pedrobaeza merged commit 9689147 into OCA:16.0 Nov 28, 2023
2 checks passed
@pedrobaeza pedrobaeza deleted the 16.0-mig-payment_stripe branch November 28, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants