[ADD] 17.0 analysis

[StefanRijnhart]

No description provided.

[legalsylvain]

Minor remarks inline.

Thanks for initializing OpenUpgrade 17.0 !

[legalsylvain]

Suggested change

	This module is a containers of migration script to migrate from 15.0 to
	16.0 version.
	This module is a containers of migration script to migrate from 16.0 to
	17.0 version.

[StefanRijnhart]

Thanks, fixed now!

[legalsylvain]

Why this change ?
As soon as merging a PR in openupgradelib doens't generate a new package on pypi, I guess that we should keep the url "openupgradelib @ git+https://github.com/OCA/openupgradelib@master"

Don't you think ?

[StefanRijnhart]

Thanks! Fixed by setting the external dependency in the module manifest to this git notation.

[legalsylvain]

/ocabot migration openupgrade_scripts

[legalsylvain]

This file is empty. FYI, I began a list of renamed / merged Odoo modules here :
#4124 (comment)

[StefanRijnhart]

Thanks! Great work on the renamed and merge modules. I updated apriori with it and reran the analysis.

[alexisadrianc]

👍

[legalsylvain]

Thanks !

/ocabot merge nobump

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-4294-by-legalsylvain-bump-nobump, awaiting test results.

[OCA-git-bot]

@legalsylvain The merge process could not be finalized, because command twine upload --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_openupgrade_scripts-17.0.1.0.0.3-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading odoo_addon_openupgrade_scripts-17.0.1.0.0.3-py3-none-any.whl
�[?25l
�[2K�[35m  0%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m0.0/478.7 kB�[0m • �[36m--:--�[0m • �[31m?�[0m
�[2K�[35m  0%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m0.0/478.7 kB�[0m • �[36m--:--�[0m • �[31m?�[0m
�[2K�[35m  0%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m0.0/478.7 kB�[0m • �[36m--:--�[0m • �[31m?�[0m
�[2K�[35m 17%�[0m �[91m━━━━━━�[0m�[91m╸�[0m�[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m81.9/478.7 kB�[0m • �[36m00:01�[0m • �[31m37.1 MB/s�[0m
�[2K�[35m 33%�[0m �[91m━━━━━━━━━━━━━�[0m�[90m╺�[0m�[90m━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m155.6/478.7 kB�[0m • �[36m00:01�[0m • �[31m1.4 MB/s�[0m
�[2K�[35m 53%�[0m �[91m━━━━━━━━━━━━━━━━━━━━━�[0m�[90m╺�[0m�[90m━━━━━━━━━━━━━━━━━━�[0m �[32m254.0/478.7 kB�[0m • �[36m00:01�[0m • �[31m1.1 MB/s�[0m
�[2K�[35m 91%�[0m �[91m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m�[90m╺�[0m�[90m━━━�[0m �[32m434.2/478.7 kB�[0m • �[36m00:01�[0m • �[31m1.3 MB/s�[0m
�[2K�[35m100%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m478.7/478.7 kB�[0m • �[33m00:00�[0m • �[31m1.1 MB/s�[0m
�[2K�[35m100%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m478.7/478.7 kB�[0m • �[33m00:00�[0m • �[31m1.1 MB/s�[0m
�[2K�[35m100%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m478.7/478.7 kB�[0m • �[33m00:00�[0m • �[31m1.1 MB/s�[0m
�[2K�[35m100%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m478.7/478.7 kB�[0m • �[33m00:00�[0m • �[31m1.1 MB/s�[0m
�[2K�[35m100%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m478.7/478.7 kB�[0m • �[33m00:00�[0m • �[31m1.1 MB/s�[0m
�[2K�[35m100%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m478.7/478.7 kB�[0m • �[33m00:00�[0m • �[31m1.1 MB/s�[0m
�[?25h�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         Invalid value for requires_dist. Error: Can't have direct dependency:  
         'openupgradelib @ git+https://github.com/OCA/openupgradelib.git@master'

[legalsylvain]

@sbidoul : maybe do you have an idea about the correct syntax to add git dependency for python package.
here is the current code :

    "external_dependencies": {
        "python": [
            "openupgradelib @ git+https://github.com/OCA/openupgradelib.git@master"
        ]
    },

[sbidoul]

@legalsylvain it's

"external_dependencies": {
        "python": [
            "openupgradelib"
        ]
    },

There is no way to declare the git URL in external dependencies.

[legalsylvain]

There is no way to declare the git URL in external dependencies.

I mean, in V16 or before, there was a way to define alternative package in setup.py. There is a way to mention git url in pyproject.toml ?

[sbidoul]

I mean, in V16 or before, there was a way to define alternative package in setup.py.

External dependencies overrides are still possible with pyproject.toml.

There is a way to mention git url in pyproject.toml ?

That (a git URL) was not possible with setup.py either.

The only place we can do this is in test-requirements.txt, IIRC.

[legalsylvain]

Thanks a lot @sbidoul