Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][OU-IMP] account, hr_holidays: update multi-company ir_rule #4361

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

remi-filament
Copy link
Contributor

Update multi-company ir_rule to align with odoo/odoo#158437
Related to #4356

@remi-filament
Copy link
Contributor Author

I have some doubt about this PR, since in the mean time hr_holidays was updated to v1.6 with odoo/odoo@d59e645
upgrade_analysis module therefore created me a 16.0.1.6 directory in hr_holidays (same applied to project with version 1.3)

I am not sure what should be done here, should I update in 16.0.1.5 still or should I create a new 16.0.1.6 with potentially only this change inside ?

@legalsylvain @pedrobaeza you probably know : How will OpenUpgrade behave if we try to migrate hr_holidays from 15.0.1.5 to 16.0.1.6 ? Will it apply scripts from 16.0.1.5 still or would it be looking only for scripts in a hr_holidays/16.0.1.6 directory ?

@pedrobaeza pedrobaeza added this to the 16.0 milestone Mar 27, 2024
@pedrobaeza
Copy link
Member

I think we should move everything to the latest core available version. Odoo is executing each pre- scripts from older version to newer one, and after update module, all the post- scripts, so it's better to reduce side effects putting everything in the same latest version.

@remi-filament
Copy link
Contributor Author

Thanks @pedrobaeza so I updated hr_holidays version to 1.6 as well in this PR (and made another PR for updating project version)

@pedrobaeza pedrobaeza merged commit 780ae23 into OCA:16.0 Mar 28, 2024
2 checks passed
@remi-filament remi-filament deleted the 16.0-ou-imp-ir_rules branch March 28, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants