Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][OU-ADD] base: Migration scripts #4582

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Conversation

pedrobaeza
Copy link
Member

Supersede of #4430, as there are no push rights there, and Viindoo has said that they are not working more on the migration scripts for now.

Changes performed over existing PR:

  • Comment some non desirable noupdate=1 changes
  • Handle properly ir.actions.server update conversion
  • Handle properly the private type removal
  • Reformat analysis work file
  • Other minor adjustments

@Tecnativa TT49290

@pedrobaeza
Copy link
Member Author

/ocabot migration base

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Oct 11, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 11, 2024
99 tasks
@pedrobaeza pedrobaeza force-pushed the v17_ou_add_base branch 3 times, most recently from d5f001a to 3fe2073 Compare October 11, 2024 09:27
- Comment some non desirable noupdate=1 changes
- Handle properly ir.actions.server update conversion
- Handle properly the private type removal
- Reformat analysis work file
- Other minor adjustments
@pedrobaeza
Copy link
Member Author

OK, let's merge this as a "base" (wordgame, hehe) for continuing doing the rest of the scripts, and with real tests, we can refine it.

@pedrobaeza pedrobaeza merged commit 9a19b66 into OCA:17.0 Oct 11, 2024
2 checks passed
@pedrobaeza pedrobaeza deleted the v17_ou_add_base branch October 11, 2024 10:19
@remi-filament
Copy link
Contributor

Thanks @pedrobaeza for taking over this base module migration.

From what I can see, the only point that might be problematic during migrations is about ir_act_server with state = 'action_create'. I understand we lose functionalities to set multiple values with new Odoo way of using ir_act_server, maybe we should make it clear somewhere (in the logs or elsewhere ?), I know you point it in upgrade_analysis_work.txt but I am not sure it is visible enough ?
Also you chose to use only field = "name", which should cover most of the cases, also there are probably corner cases where main field of model is not called "name" but should be the one to fill in, yet it should apply to most cases so maybe we could also cover this limitation in documentation somewhere ?

@pedrobaeza
Copy link
Member Author

Yes, right now we don't have a centralized place where informing all of this. Odoo enterprise is putting a chat conversation for system administrators. We may mimic that approach, but sometimes the people reading that may not be suitable to act.

And also specifically about actions servers, you shouldn't based your developments on actions servers if you want to be a serious integrator.

@remi-filament
Copy link
Contributor

Yes, right now we don't have a centralized place where informing all of this. Odoo enterprise is putting a chat conversation for system administrators. We may mimic that approach, but sometimes the people reading that may not be suitable to act.

Yes maybe, I have seen it indeed only when updating localisation that they left a message in chat. Maybe all people reading that would not be suitable to act, but in general after a migration I always connect with administrator account to check a few things so I would get the information which seems a good solution !

And also specifically about actions servers, you shouldn't based your developments on actions servers if you want to be a serious integrator.

👍

@pedrobaeza
Copy link
Member Author

One of the OpenUpgrade principles is to provide a full migration process, including opinionated decisions when there are several choices, so the number of these entries to check should be minimum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants