Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][OU-ADD] gamification: Migration to 17.0 #4625

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

acpMicrocom
Copy link
Contributor

No description provided.

@legalsylvain
Copy link
Contributor

legalsylvain commented Oct 24, 2024

/ocabot migration gamification

Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it is complete.

I believe the ir_cron_consolidate_last_month xml reference of this v16 cron https://github.com/odoo/odoo/blob/16.0/addons/gamification/data/ir_cron_data.xml#L15 should be renamed to ir_cron_consolidate in the migration, see https://github.com/odoo/odoo/blob/17.0/addons/gamification/data/ir_cron_data.xml#L15 .

I'm also not sure, but may be the karma computation should be triggered, See the change here https://github.com/akretion/odoo-module-diff-analysis/blob/main/17.0/gamification/c000__________-%23_76430_imp-gamification-website-forum-website-slides-karma-tracking-improveme.patch
I'm not sure about this last one.

@acpMicrocom
Copy link
Contributor Author

I'm also not sure, but may be the karma computation should be triggered, See the change here https://github.com/akretion/odoo-module-diff-analysis/blob/main/17.0/gamification/c000__________-%23_76430_imp-gamification-website-forum-website-slides-karma-tracking-improveme.patch
I'm not sure about this last one.

@rvalyi Thank you for the feedback.

I noticed that the karma field update doesn't appear in the upgrade_analysis.txt. Could you advise on the best approach to ensure the computation is triggered in this case? Should we add it manually, or is there another recommended method to handle fields that aren't included in the analysis file?

Thanks in advance for your guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants