Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][OU-ADD] account: Migration to 17.0 #4662

Closed
wants to merge 3 commits into from

Conversation

pedrobaeza
Copy link
Member

Continuation of #4457

@Tecnativa TT49274

@pedrobaeza
Copy link
Member Author

/ocabot migration account

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 11, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 11, 2024
99 tasks
@pedrobaeza
Copy link
Member Author

@hbrunn do you want to work on the rest?

openupgrade.logged_query(
env.cr,
f"""UPDATE account_tax
SET description = {'en_US': {openupgrade.get_legacy_name('description')}}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not working yet.

@hbrunn
Copy link
Member

hbrunn commented Nov 11, 2024

@pedrobaeza can you make this PR writable for maintainers?

@pedrobaeza
Copy link
Member Author

I'm afraid it's something of GitHub itself, as it has been pushed from a organization branch. Feel free to open a new one if you finish it. There's now a CI problem whose roots have been investigated here: Tecnativa/doodba#636

@legalsylvain
Copy link
Contributor

Indeed.

  • If pedro creates a branch on his personal space (pedrobaeza) such option are available :

image

  • But if he creates a branch on his organization space (Tecnativa), no option is available.

(tested with my legalsylvain / grap branches)

@hbrunn
Copy link
Member

hbrunn commented Nov 11, 2024

I won't be able to add anything today, will have a look if there's anything left over next Monday

@hbrunn
Copy link
Member

hbrunn commented Nov 11, 2024

PS: Let's then to PRs from our personal forks to facilitate collaboration in the future

@pedrobaeza
Copy link
Member Author

OK, I will continue with this PR during the week.

I won't be able to add anything today, will have a look if there's anything left over next Monday

Yeah, it was the habit, as in our team we always push everything to Tecnativa to promote that collaboration (as others don't have repo maintainer role).

@legalsylvain
Copy link
Contributor

PS: Let's then to PRs from our personal forks to facilitate collaboration in the future

We can also make a PR on OpenUpgrade repo. (OpenUpgrade:17.0-account) So all the maintainers can push on it.
Pro : better collaboration. Cons : corporate OCA statistics doesn't include such work. (= how many PRs are done by tecnativa each years.)
Maybe such things could be done only for 2 or 3 PR per revision, for modules that requires huge work (like account, or base, ...)

@hbrunn
Copy link
Member

hbrunn commented Nov 18, 2024

good idea about pushing to /oca, will do. Continuing this now

@hbrunn
Copy link
Member

hbrunn commented Nov 18, 2024

superseded by #4668

@hbrunn hbrunn closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants