Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][OU-IMP] new analysis (december 2024) #4697

Merged
merged 1 commit into from
Dec 18, 2024
Merged

[17.0][OU-IMP] new analysis (december 2024) #4697

merged 1 commit into from
Dec 18, 2024

Conversation

MiquelRForgeFlow
Copy link
Contributor

It hasn't changed much, as the last one was done on October (9bde91f).

I added "sale_quotation_builder": "sale_pdf_quote_builder" in apriori, because expectations. People having the old one expects having the new one after the migration, independently if the code has changed between the modules.

@MiquelRForgeFlow MiquelRForgeFlow added this to the 17.0 milestone Dec 12, 2024
hbrunn
hbrunn requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the rename should go into another commit than the analysis

openupgrade_scripts/scripts/base_import_module/17.0.1.0/upgrade_analysis_work.txt Show resolved Hide resolved
@hbrunn
Copy link
Member

hbrunn commented Dec 16, 2024

bu still I think the addition to apriori.py should go in its own commit

@MiquelRForgeFlow
Copy link
Contributor Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-4697-by-MiquelRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@MiquelRForgeFlow The merge process could not be finalized, because command git push origin 17.0-ocabot-merge-pr-4697-by-MiquelRForgeFlow-bump-nobump:17.0 failed with output:

To https://github.com/OCA/OpenUpgrade
 ! [remote rejected]         17.0-ocabot-merge-pr-4697-by-MiquelRForgeFlow-bump-nobump -> 17.0 (cannot lock ref 'refs/heads/17.0': is at c11820e89e80a3a8d4eed199d47286132f17851f but expected fdde3955a2037a2e90018da99b6ca97c1dd9942a)
error: failed to push some refs to 'https://github.com/OCA/OpenUpgrade'

@OCA-git-bot OCA-git-bot merged commit c11820e into OCA:17.0 Dec 18, 2024
2 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c11820e. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 17.0-upd-new_analysis branch December 18, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legalsylvain legalsylvain legalsylvain left review comments

@hbrunn hbrunn hbrunn approved these changes

@pedrobaeza pedrobaeza Awaiting requested review from pedrobaeza

Assignees
No one assigned
Labels
merged 🎉 needs review
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@MiquelRForgeFlow @hbrunn @OCA-git-bot @legalsylvain @pedrobaeza