-
-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(WIP) Product v8 migration #9
Closed
Closed
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
dc2b11e
First part of product migration analysis.
gurneyalex 1252ab4
fix missing dependency in product in v8
gurneyalex 1240331
updated product migration analysis
gurneyalex d8f8b1b
first pass at product migration script
gurneyalex adb73d2
fix bad refactoring
gurneyalex 776c954
compute active attribute of template from attribute of variants
gurneyalex db73bf7
copy product_product.image to product_product.image_variant
gurneyalex 2e9f1a6
updated work analysis
gurneyalex 978684c
migration of product.packaging and product.ul
gurneyalex c684512
migration of product_template.cost_method, moved in stock_account
guewen 08fd7aa
reinstall data from product moved to mrp
gurneyalex 81da4ed
add migration for product.packaging to template
gurneyalex dd941af
fix error in previous refactoring
gurneyalex b185b32
Merge branch 'product-v8-migration' of https://github.com/guewen/Open…
gurneyalex be0576e
packaging field is o2m -> no colum renaming required
gurneyalex c6e21ee
fix packaging/ul migration
gurneyalex 6afa1a6
re-add the change on product consultant
gurneyalex 2f10573
added AGPL header
gurneyalex 0bbfeb6
fix typo
gurneyalex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
from openerp.openupgrade import openupgrade | ||
from openerp import pooler, SUPERUSER_ID | ||
|
||
def move_fields(cr, pool): | ||
execute = openupgrade.logged_query | ||
queries = [ """ | ||
UPDATE product_product | ||
SET produce_delay=(SELECT pt.%s | ||
FROM product_template | ||
WHERE product_template.id=product_product.product_tmpl_id) | ||
""" % openupgrade.get_legacy_name('produce_delay'), | ||
|
||
|
||
@openupgrade.migrate() | ||
def migrate(cr, version): | ||
pool = pooler.get_pool(cr.dbname) | ||
move_fields(cr, pool) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,7 @@ | |
'version': '1.1', | ||
'author': 'OpenERP SA', | ||
'category': 'Sales Management', | ||
'depends': ['base', 'decimal_precision', 'mail'], | ||
'depends': ['base', 'decimal_precision', 'mail', 'report'], | ||
'demo': [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this added dependency an upstream issue, or OpenUpgrade specific? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a bug in v8. There's an issue and a PR for this upstream. |
||
'product_demo.xml', | ||
'product_image_demo.xml', | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
<?xml version='1.0' encoding='utf-8'?> | ||
<openerp> | ||
<data> | ||
<record id="product_supplierinfo_comp_rule" model="ir.rule"><field name="domain_force">['|',('company_id','=',False),('company_id','=',user.company_id.id)]</field> | ||
</record> | ||
<record id="product_pricelist_comp_rule" model="ir.rule"><field name="domain_force"> ['|',('company_id','=',user.company_id.id),('company_id','=',False)]</field> | ||
</record> | ||
<record id="product_uom_kgm" model="product.uom"><field name="rounding" eval="0.001"/> | ||
</record> | ||
<record id="item0" model="product.pricelist.item"><field name="sequence">1000</field> | ||
</record> | ||
<record id="product_category_all" model="product.category"><field name="name">All</field> | ||
</record> | ||
<record id="product_pricelist_version_comp_rule" model="ir.rule"><field name="domain_force"> ['|',('company_id','=',user.company_id.id),('company_id','=',False)]</field> | ||
</record> | ||
<record id="product_pricelist_item_comp_rule" model="ir.rule"><field name="domain_force"> ['|',('company_id','=',user.company_id.id),('company_id','=',False)]</field> | ||
</record> | ||
<record id="product_comp_rule" model="ir.rule"><field name="domain_force"> ['|',('company_id','=',user.company_id.id),('company_id','=',False)]</field> | ||
</record> | ||
<record id="product_product_consultant" model="product.product"><field name="sale_ok" eval="False"/> | ||
</record> | ||
</data> | ||
</openerp> | ||
|
154 changes: 154 additions & 0 deletions
154
addons/product/migrations/8.0.1.1/openupgrade_analysis_WORK.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,154 @@ | ||
---Fields in module 'product'--- | ||
product / product.attribute / name (char) : NEW required: required | ||
product / product.attribute / value_ids (one2many) : NEW relation: product.attribute.value | ||
product / product.attribute.line / attribute_id (many2one) : NEW relation: product.attribute, required: required | ||
product / product.attribute.line / product_tmpl_id (many2one) : NEW relation: product.template, required: required | ||
product / product.attribute.line / value_ids (many2many) : NEW relation: product.attribute.value | ||
product / product.attribute.price / price_extra (float) : NEW | ||
product / product.attribute.price / product_tmpl_id (many2one) : NEW relation: product.template, required: required | ||
product / product.attribute.price / value_id (many2one) : NEW relation: product.attribute.value, required: required | ||
product / product.attribute.value / attribute_id (many2one) : NEW relation: product.attribute, required: required | ||
product / product.attribute.value / name (char) : NEW required: required | ||
product / product.attribute.value / price_ids (one2many) : NEW relation: product.attribute.price | ||
product / product.attribute.value / product_ids (many2many) : NEW relation: product.product | ||
product / product.attribute.value / sequence (integer) : NEW | ||
|
||
## OK new model, will be handled by standard migration | ||
|
||
|
||
product / product.packaging / ul_container (many2one) : NEW relation: product.ul | ||
product / product.packaging / height (float) : DEL | ||
product / product.ul / height (float) : NEW | ||
product / product.packaging / length (float) : DEL | ||
product / product.ul / length (float) : NEW | ||
product / product.packaging / weight_ul (float) : DEL | ||
product / product.ul / weight (float) : NEW | ||
product / product.packaging / width (float) : DEL | ||
product / product.ul / width (float) : NEW | ||
## OK new relation ul_container handled by migration | ||
## OK the dimensions are weight must be moved to the related UL (through the ul field) | ||
|
||
|
||
product / product.price.history / company_id (many2one) : NEW relation: res.company, required: required, req_default: function | ||
product / product.price.history / cost (float) : NEW | ||
product / product.price.history / datetime (datetime) : NEW | ||
product / product.price.history / product_template_id (many2one): NEW relation: product.template, required: required | ||
# OK new fields -> nothing to do | ||
|
||
product / product.template / attribute_line_ids (one2many) : NEW relation: product.attribute.line | ||
product / product.product / attribute_value_ids (many2many): NEW relation: product.attribute.value | ||
# OK nothing to do | ||
|
||
|
||
product / product.supplierinfo / product_id (many2one) : DEL relation: product.template, required: required | ||
product / product.supplierinfo / product_tmpl_id (many2one) : NEW relation: product.template, required: required | ||
# OK seller_ids moved from product.product to product.template | ||
|
||
product / product.template / active (boolean) : NEW | ||
# OK: set to True if at least one variant is active | ||
|
||
product / product.template / color (integer) : NEW | ||
product / product.product / color (integer) : DEL | ||
## OK color moved up in template | ||
|
||
product / product.template / cost_method (selection) : module is now 'stock_account' ('product') | ||
product / product.template / cost_method (selection) : now a function | ||
product / product.template / cost_method (selection) : selection_keys is now '['average', 'real', 'standard']' ('['average', 'standard']') | ||
# moved in stock_account, now a fields.property | ||
|
||
product / product.template / image (binary) : NEW | ||
product / product.product / image (binary) : now afunction | ||
# OK need to move up to template | ||
|
||
product / product.product / image_variant (binary) : NEW | ||
# nothing to do | ||
|
||
product / product.template / message_ids (one2many) : NEW relation: mail.message | ||
product / product.template / message_last_post (datetime) : NEW | ||
# now product.template derives from mail template | ||
# TODO : move up messages -> they will still be on the product so why bother | ||
product / product.product / message_last_post (datetime) : NEW | ||
|
||
|
||
product / product.template / packaging (one2many) : NEW relation: product.packaging | ||
# OK moved from product.product | ||
|
||
product / product.template / produce_delay (float) : DEL | ||
# OK moved in mrp, defined on product.product | ||
|
||
product / product.template / product_variant_ids (one2many): NEW relation: product.product, required: required | ||
# nothing to do? | ||
|
||
product / product.template / standard_price (float) : now a function | ||
# nothing to do | ||
|
||
product / product.product / incoming_qty (float) : module is now 'stock' ('product') | ||
# function field nothing to do | ||
|
||
product / product.product / outgoing_qty (float) : module is now 'stock' ('product') | ||
product / product.product / price_extra (float) : now a function | ||
product / product.product / price_margin (float) : DEL | ||
product / product.product / qty_available (float) : module is now 'stock' ('product') | ||
product / product.product / variants (char) : DEL | ||
product / product.product / virtual_available (float) : module is now 'stock' ('product') | ||
|
||
|
||
|
||
---XML records in module 'product'--- | ||
NEW ir.actions.act_window: product.product_template_action | ||
NEW ir.actions.act_window: product.product_variant_action | ||
NEW ir.actions.act_window: product.variants_template_action | ||
DEL ir.actions.act_window: product.product_normal_action_puchased | ||
DEL ir.actions.act_window: product.product_template_action_tree | ||
DEL ir.actions.act_window.view: product.open_view_product_form1 | ||
DEL ir.actions.act_window.view: product.open_view_product_kanban1 | ||
DEL ir.actions.act_window.view: product.open_view_product_tree1 | ||
NEW ir.actions.report.xml: product.action_report_pricelist | ||
DEL ir.actions.report.xml: product.report_product_pricelist | ||
## ir.actions: the doc says we can safely ignore these | ||
|
||
NEW ir.model.access: product.access_product_attribute | ||
NEW ir.model.access: product.access_product_attribute_line | ||
NEW ir.model.access: product.access_product_attribute_line_sale_manager | ||
NEW ir.model.access: product.access_product_attribute_price | ||
NEW ir.model.access: product.access_product_attribute_price_sale_manager | ||
NEW ir.model.access: product.access_product_attribute_sale_manager | ||
NEW ir.model.access: product.access_product_attribute_value | ||
NEW ir.model.access: product.access_product_attribute_value_sale_manager | ||
NEW ir.model.access: product.access_product_price_history_employee | ||
## access rules: let them be for now | ||
|
||
|
||
NEW ir.ui.menu: product.menu_product_template_action | ||
NEW ir.ui.view: product.product_template_form_view_variant_button | ||
NEW ir.ui.view: product.product_template_kanban_view | ||
NEW ir.ui.view: product.product_template_kanban_view_variant_button | ||
NEW ir.ui.view: product.product_template_search_view | ||
NEW ir.ui.view: product.report_pricelist | ||
NEW ir.ui.view: product.variants_template_tree_view | ||
DEL ir.ui.view: product.product_variant_form_view | ||
DEL ir.ui.view: product.product_variant_tree_view | ||
DEL ir.ui.view_sc: product.ir_ui_view_sc_product0 | ||
## ir.ui.* doc says we can ignore | ||
|
||
DEL process.node: product.process_node_product0 | ||
DEL process.node: product.process_node_supplier0 | ||
DEL process.process: product.process_process_productprocess0 | ||
DEL process.transition: product.process_transition_supplierofproduct0 | ||
## process addon removed -> nothing to do | ||
|
||
NEW product.uom: product.product_uom_floz | ||
NEW product.uom: product.product_uom_foot | ||
NEW product.uom: product.product_uom_gal | ||
NEW product.uom: product.product_uom_inch | ||
NEW product.uom: product.product_uom_lb | ||
NEW product.uom: product.product_uom_mile | ||
NEW product.uom: product.product_uom_oz | ||
NEW product.uom: product.product_uom_qt | ||
## great new stuff, std upgrade should work by itself | ||
|
||
DEL res.groups: product.group_costing_method | ||
DEL res.groups: product.group_product_variant | ||
## well... probably nothing to do either... | ||
|
||
## modified no update records listed in modified_data.xml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
# -*- coding: utf-8 -*- | ||
############################################################################## | ||
# | ||
# Author: Alexandre Fayolle | ||
# Copyright 2014 Camptocamp SA | ||
# | ||
# This program is free software: you can redistribute it and/or modify | ||
# it under the terms of the GNU Affero General Public License as | ||
# published by the Free Software Foundation, either version 3 of the | ||
# License, or (at your option) any later version. | ||
# | ||
# This program is distributed in the hope that it will be useful, | ||
# but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
# GNU Affero General Public License for more details. | ||
# | ||
# You should have received a copy of the GNU Affero General Public License | ||
# along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
# | ||
############################################################################## | ||
|
||
from openerp.openupgrade import openupgrade | ||
from openerp import pooler, SUPERUSER_ID | ||
|
||
def load_data(cr): | ||
openupgrade.load_data(cr, 'product', 'migrations/8.0.1.1/modified_data.xml', mode='init') | ||
|
||
def move_fields(cr, pool): | ||
execute = openupgrade.logged_query | ||
queries = ["UPDATE product_supplierinfo " | ||
"SET product_tmpl_id=(SELECT product_tmpl_id " | ||
" FROM product_product " | ||
" WHERE product_product.id=product_supplierinfo.%s) " \ | ||
% openupgrade.get_legacy_name('product_id'), | ||
# | ||
"UPDATE product_template as pt " | ||
"SET color=(SELECT pp1.%s " | ||
" FROM product_product as pp1 " | ||
" WHERE pp1.product_tmpl_id=pt.id ORDER BY pp1.id LIMIT 1), " | ||
" image=(SELECT pp2.image_variant " | ||
" FROM product_product as pp2 " | ||
" WHERE pp2.product_tmpl_id=pt.id ORDER BY pp2.id LIMIT 1)" | ||
% (openupgrade.get_legacy_name('color'), | ||
) | ||
# | ||
|
||
] | ||
for sql in queries: | ||
execute(cr, sql) | ||
|
||
def copy_fields(cr, pool): | ||
product_tmpl= pool['product.template'] | ||
product_obj= pool['product.product'] | ||
# copy the active field from product to template | ||
ctx = {'active_test': False} | ||
tmpl_ids = product_tmpl.search(cr, SUPERUSER_ID, [], context=ctx) | ||
for template in product_tmpl.browse(cr, SUPERUSER_ID, tmpl_ids, context=ctx): | ||
template.write({'active': any(variant.active | ||
for variant in template.product_variant_ids) | ||
}) | ||
|
||
def migrate_packaging(cr, pool): | ||
"""create 1 product UL for each different product packaging dimension | ||
and link it to the packagings | ||
""" | ||
packaging_obj = pool['product.packaging'] | ||
ul_obj = pool['product.ul'] | ||
execute = openupgrade.logged_query | ||
legacy_columns = dict((key, openupgrade.get_legacy_name(key)) | ||
for key in ('height', 'width', | ||
'length', 'weight_ul')) | ||
execute(cr, | ||
'select ul, %(height)s, %(width)s, %(length)s, %(weight_ul)s ' | ||
'from product_packaging' % legacy_columns) | ||
for ul_id, height, width, length, weight in cr.fetchall(): | ||
ul_obj.write(cr, SUPERUSER_ID, [ul_id], | ||
{'height': height, | ||
'width': width, | ||
'length': length, | ||
'weight': weight, | ||
}) | ||
|
||
@openupgrade.migrate() | ||
def migrate(cr, version): | ||
pool = pooler.get_pool(cr.dbname) | ||
move_fields(cr, pool) | ||
copy_fields(cr, pool) | ||
migrate_packaging(cr, pool) | ||
load_data(cr) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
# -*- coding: utf-8 -*- | ||
############################################################################## | ||
# | ||
# Author: Alexandre Fayolle | ||
# Copyright 2014 Camptocamp SA | ||
# | ||
# This program is free software: you can redistribute it and/or modify | ||
# it under the terms of the GNU Affero General Public License as | ||
# published by the Free Software Foundation, either version 3 of the | ||
# License, or (at your option) any later version. | ||
# | ||
# This program is distributed in the hope that it will be useful, | ||
# but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
# GNU Affero General Public License for more details. | ||
# | ||
# You should have received a copy of the GNU Affero General Public License | ||
# along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
# | ||
############################################################################## | ||
|
||
from openerp.openupgrade import openupgrade | ||
|
||
column_renames = { | ||
# Using magic None value to trigger call to get_legacy_name() | ||
'product_supplierinfo': [ | ||
('product_id', None), | ||
], | ||
'product_product': [ | ||
('color', None), | ||
('image', 'image_variant'), | ||
], | ||
'product_template': [ | ||
('produce_delay', None), # need to handle in mrp migration | ||
('cost_method', None), # need to handle in stock_account migration | ||
], | ||
'product_packaging': [ | ||
('height', None), | ||
('length', None), | ||
('weight_ul', None), | ||
('width', None), | ||
] | ||
} | ||
|
||
|
||
@openupgrade.migrate() | ||
def migrate(cr, version): | ||
openupgrade.rename_columns(cr, column_renames) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the AGPL header and and enjoy the copyrights!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copylefts ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed