[17.0][MIG] account_analytic_parent #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed groups attribute in tree xml element. * Removed discarded hierarchical tree view support, plus wizard based on that functionality
Currently translated at 100,0% (4 of 4 strings) Translation: account-analytic-11.0/account-analytic-11.0-account_analytic_parent Translate-URL: https://translation.odoo-community.org/projects/account-analytic-11-0/account-analytic-11-0-account_analytic_parent/de/
Currently translated at 100,0% (4 of 4 strings) Translation: account-analytic-11.0/account-analytic-11.0-account_analytic_parent Translate-URL: https://translation.odoo-community.org/projects/account-analytic-11-0/account-analytic-11-0-account_analytic_parent/ca/
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (5 of 5 strings) Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/es/
Currently translated at 100.0% (5 of 5 strings) Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/gl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/
Currently translated at 54.5% (6 of 11 strings) Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/nl/
Currently translated at 100.0% (11 of 11 strings) Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/hr/
Currently translated at 18.2% (2 of 11 strings) Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/fr/
Currently translated at 90.9% (10 of 11 strings) Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/es/
This is to resolve conflict with `account_analytic_sequence` module.
Currently translated at 100.0% (11 of 11 strings) Translation: account-analytic-15.0/account-analytic-15.0-account_analytic_parent Translate-URL: https://translation.odoo-community.org/projects/account-analytic-15-0/account-analytic-15-0-account_analytic_parent/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-analytic-16.0/account-analytic-16.0-account_analytic_parent Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-account_analytic_parent/
Currently translated at 100.0% (10 of 10 strings) Translation: account-analytic-16.0/account-analytic-16.0-account_analytic_parent Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-account_analytic_parent/it/
Comment on lines
+12
to
+14
| <field name="plan_id" position="after"> | ||
| <field name="parent_id" string="Parent Analytic Account" /> | ||
| </field> |
There was a problem hiding this comment.
Suggested change
| <field name="plan_id" position="after"> | |
| <field name="parent_id" string="Parent Analytic Account" /> | |
| </field> | |
| <group name="main" position="attributes"> | |
| <attribute name="string">General</attribute> | |
| </group> | |
| <group name="main" position="before"> | |
| <group name="parent" col="2"> | |
| <field name="parent_id" class="oe_inline"/> | |
| </group> | |
| </group> |
As a general improvement. I guess that it makes more sense to have the view in a similar structure as in the Product Category, where we also have a Parent-Child relation.
In order to adapt, we also could name the original group with the "General" string. What do you think?
| @@ -0,0 +1,448 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
Suggested change
| <?xml version="1.0" encoding="utf-8"?> |
XML declarations in HTML module descriptions are deprecated in Odoo 17
AndreuOForgeFlow
approved these changes
Mar 15, 2024
dreispt
approved these changes
Mar 18, 2024
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
/ocabot migration account_analytic_parent |
|
Congratulations, your PR was merged at f05dc71. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to 17.0
@ForgeFlow