[16.0][IMP] stock_analytic: make analytic distribution consistent between move and move line #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AungKoKoLin1997
force-pushed
the
4515-imp-stock_analytic
branch
from
9d93712
to
b59d268
Compare
kanda999
suggested changes
May 10, 2024
stock_analytic/models/stock_move.py
Outdated
| @@ -72,6 +72,7 @@ def _action_done(self, cancel_backorder=False): | |||
| "company_id": move.company_id.id, | |||
| } | |||
| ) | |||
| move.move_line_ids.analytic_distribution = move.analytic_distribution | |||
There was a problem hiding this comment.
move.move_line_ids.analytic_distribution = move.analytic_distribution should be on line 62.
Otherwise, during moves such as receipts, the analytic distribution of move_lines will not be updated.
AungKoKoLin1997
force-pushed
the
4515-imp-stock_analytic
branch
from
b59d268
to
55f28ec
Compare
AungKoKoLin1997
force-pushed
the
4515-imp-stock_analytic
branch
from
55f28ec
to
f7e9deb
Compare
AungKoKoLin1997
force-pushed
the
4515-imp-stock_analytic
branch
from
f7e9deb
to
38508f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the consistency between moves and move lines for analytic_distribution. When the value is changed in one, it will also be updated in the other.
@qrtl QT4515