[IMP] mis_builder: _get_additional_query_filter on period model #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more consistent in case we want to have an analytic filter on the columns.
|
👍 |
|
👍 Thanks to for your insights @sbidoul This would be the result of use with separate module "mis_builder_analytic_account". I'll propose a separate PR for that: |
|
👍 |
1 similar comment
|
👍 |
pedrobaeza
added a commit
that referenced
this pull request
Nov 6, 2015
[IMP] mis_builder: _get_additional_query_filter on period model
rconjour
pushed a commit
to EssentNovaTeam/account-financial-reporting
that referenced
this pull request
Mar 16, 2020
Change separator of author in manifest to be displayed correctly in apps...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a better api that is more consistent in case we want to have an analytic filter on the columns.
Thanks @jbeficent for the productive discussion and tests of this new API.