[11.0][FIX] account_global_discount: link line taxes to discount move line #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
approved these changes
Jun 30, 2020
chienandalu
force-pushed
the
11.0-fix-disc-aml-tax
branch
from
048122d to
89f6a5c
Compare
|
please review @carlosdauden |
chienandalu
force-pushed
the
11.0-fix-disc-aml-tax
branch
from
89f6a5c to
1da9249
Compare
chienandalu
force-pushed
the
11.0-fix-disc-aml-tax
branch
from
1da9249 to
d2f508a
Compare
carlosdauden
suggested changes
Jun 30, 2020
|
@carlosdauden please check my latest changes |
pedrobaeza
force-pushed
the
11.0-fix-disc-aml-tax
branch
4 times, most recently
from
d1f5859 to
fcd1690
Compare
pedrobaeza
changed the title
pedrobaeza
added a commit
to Tecnativa/sale-workflow
that referenced
this pull request
Jul 3, 2020
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
pedrobaeza
added a commit
to Tecnativa/sale-workflow
that referenced
this pull request
Jul 3, 2020
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
pedrobaeza
added a commit
to Tecnativa/sale-workflow
that referenced
this pull request
Jul 3, 2020
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
pedrobaeza
force-pushed
the
11.0-fix-disc-aml-tax
branch
from
fcd1690 to
a6d211d
Compare
chienandalu
commented
Jul 13, 2020
There was a problem hiding this comment.
Tested @pedrobaeza changes 👍
@carlosdauden Please re-review
|
This PR isn't ok, at the accounting entry of discount, I miss the detail of 349 model on intra-community invoices:
Please, could you check it @chienandalu ? Thanks a lot! |
|
@SoniaViciana this is because you need a glue module between both. It's the problem of having this anti-nature way of giving discounts. We have been forced to do it in a customer, but we DON'T RECOMMEND these global discounts as it needs a lot of patching in successive things, like this 349 side effect. |
- We need to take into account invoice lines with multiple taxes, so the link should be m2m. - Migration scripts for preserving the best information on existing installations. - Tests for checking new conditions. - Perform sanity check for not ending in an incompatible situation. - Some refactor done on onchanges for avoiding duplicating operations. - Adjust UI for not allowing to edit computed invoice global discounts.
pedrobaeza
force-pushed
the
11.0-fix-disc-aml-tax
branch
from
a6d211d to
0ae672d
Compare
|
@SoniaViciana @chienandalu I think I have found method for not needing that glue modules in most cases. Can you please check with latest push about the 349? |
|
Well, not sure if we need to change 349 method: and doing this in invoice_line_move_line_get instead. And even in that case, it would depend on the call chain... I'm giving up now on this, as our customer only uses global discounts for national operations (and in very few cases). |
|
Yes, looks like a glue module is still needed for that case: https://github.com/OCA/l10n-spain/blob/245ff2527aabd2670c99325a056651fef5cfce3f/l10n_es_aeat_mod349/models/account_invoice.py#L35-L36 Anyway, let's move forward |
|
/ocabot merge patch |
kirca
pushed a commit
to archeti-org/sale-workflow
that referenced
this pull request
Feb 17, 2022
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
omar7r
pushed a commit
to Comunitea/sale-workflow
that referenced
this pull request
Feb 21, 2022
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
xavier-bouquiaux
pushed a commit
to acsone/sale-workflow
that referenced
this pull request
Jun 13, 2022
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
dreispt
pushed a commit
to ursais/sale-workflow
that referenced
this pull request
Jun 21, 2022
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
kirca
pushed a commit
to archeti-org/sale-workflow
that referenced
this pull request
Oct 25, 2022
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
alexeirivera87
pushed a commit
to archeti-org/sale-workflow
that referenced
this pull request
Jan 18, 2023
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
ferran-S73
pushed a commit
to Studio73/sale-workflow
that referenced
this pull request
Jan 20, 2023
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
kirca
pushed a commit
to archeti-org/sale-workflow
that referenced
this pull request
Feb 13, 2023
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
ferran-S73
pushed a commit
to Studio73/sale-workflow
that referenced
this pull request
Apr 17, 2023
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
ferran-S73
pushed a commit
to Studio73/sale-workflow
that referenced
this pull request
May 22, 2023
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
ferran-S73
pushed a commit
to Studio73/sale-workflow
that referenced
this pull request
Jun 19, 2023
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
RabbitJon-S73
pushed a commit
to Studio73/sale-workflow
that referenced
this pull request
Jun 26, 2023
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
hildickethan
pushed a commit
to Studio73/sale-workflow
that referenced
this pull request
Aug 8, 2023
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
pedrobaeza
added a commit
to Tecnativa/sale-workflow
that referenced
this pull request
Aug 10, 2023
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
hildickethan
pushed a commit
to Studio73/sale-workflow
that referenced
this pull request
Aug 29, 2023
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
alan196
pushed a commit
to Jarsa/sale-workflow
that referenced
this pull request
Nov 23, 2023
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
miguel-S73
pushed a commit
to Studio73/sale-workflow
that referenced
this pull request
Dec 21, 2023
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
miguel-S73
pushed a commit
to Studio73/sale-workflow
that referenced
this pull request
Mar 18, 2024
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
miguel-S73
pushed a commit
to Studio73/sale-workflow
that referenced
this pull request
Mar 18, 2024
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
alan196
pushed a commit
to Jarsa/sale-workflow
that referenced
this pull request
Apr 22, 2024
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
ferran-S73
pushed a commit
to Studio73/sale-workflow
that referenced
this pull request
Apr 30, 2024
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
ferran-S73
pushed a commit
to Studio73/sale-workflow
that referenced
this pull request
May 20, 2024
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
trisdoan
pushed a commit
to trisdoan/sale-workflow
that referenced
this pull request
Jun 10, 2024
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
trisdoan
pushed a commit
to camptocamp/sale-workflow
that referenced
this pull request
Jun 11, 2024
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
ferran-S73
pushed a commit
to Studio73/sale-workflow
that referenced
this pull request
Jun 20, 2024
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
miguel-S73
pushed a commit
to Studio73/sale-workflow
that referenced
this pull request
Aug 14, 2024
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
ferran-S73
pushed a commit
to Studio73/sale-workflow
that referenced
this pull request
Sep 27, 2024
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
bealdav
pushed a commit
to akretion/sale-workflow
that referenced
this pull request
Sep 27, 2024
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
miguel-S73
pushed a commit
to Studio73/sale-workflow
that referenced
this pull request
Nov 6, 2024
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
miguel-S73
pushed a commit
to Studio73/sale-workflow
that referenced
this pull request
Nov 19, 2024
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT24526