Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] account_statement_base: link to account move lines from statements #659

Merged
merged 1 commit into from
Sep 27, 2024
Merged

[16.0][IMP] account_statement_base: link to account move lines from statements #659

merged 1 commit into from
Sep 27, 2024

Conversation

sergiobstoj
Copy link
Member

@sergiobstoj sergiobstoj commented May 24, 2024 •
edited
Loading

Link to Account Move Lines in Statements

@OCA-git-bot
Copy link
Contributor

Hi @alexis-via,
some modules you are maintaining are being modified, check this out!

@sergiobstoj sergiobstoj force-pushed the 16.0-imp-account_statement_base-link_to_account_move_lines_from_statements branch 3 times, most recently from da018ae to cf091da Compare May 27, 2024 08:40
@sergiobstoj sergiobstoj force-pushed the 16.0-imp-account_statement_base-link_to_account_move_lines_from_statements branch 2 times, most recently from d7a19bc to b780960 Compare May 27, 2024 09:37
@sergiobstoj sergiobstoj force-pushed the 16.0-imp-account_statement_base-link_to_account_move_lines_from_statements branch from b780960 to 48f65ad Compare May 27, 2024 13:43
@sergiobstoj sergiobstoj force-pushed the 16.0-imp-account_statement_base-link_to_account_move_lines_from_statements branch 2 times, most recently from 30900ae to 765a8d6 Compare May 28, 2024 07:32
@sergiobstoj sergiobstoj force-pushed the 16.0-imp-account_statement_base-link_to_account_move_lines_from_statements branch 2 times, most recently from 345aa21 to c627ac2 Compare May 29, 2024 09:48
@sergiobstoj sergiobstoj marked this pull request as ready for review May 30, 2024 08:04
sergiobstoj added a commit to factorlibre/account-reconcile that referenced this pull request May 30, 2024
@sergiobstoj
[UPD]account_statement_base: translation for PR OCA#659
536c615
sergiobstoj added a commit to factorlibre/account-reconcile that referenced this pull request Jun 4, 2024
@sergiobstoj
[UPD]account_statement_base: translation for PR OCA#659
aa39df5
@sergiobstoj sergiobstoj force-pushed the 16.0-imp-account_statement_base-link_to_account_move_lines_from_statements branch 8 times, most recently from b172c97 to 59b69f1 Compare June 4, 2024 10:01
sergiobstoj added a commit to factorlibre/account-reconcile that referenced this pull request Jun 4, 2024
@sergiobstoj
[UPD]account_statement_base: translation for PR OCA#659
eb18ad9
sergiobstoj added a commit to factorlibre/account-reconcile that referenced this pull request Jun 4, 2024
@sergiobstoj
[UPD]account_statement_base: translation for PR OCA#659
5248c78
sergiobstoj added a commit to factorlibre/account-reconcile that referenced this pull request Jun 4, 2024
@sergiobstoj
[UPD]account_statement_base: translation for PR OCA#659
49de3fe
sergiobstoj added a commit to factorlibre/account-reconcile that referenced this pull request Jun 4, 2024
@sergiobstoj
[UPD]account_statement_base: translation for PR OCA#659
21e4dcb
@sergiobstoj
Copy link
Member Author

@alexis-via looks good to you for merge?

bencoronel pushed a commit to factorlibre/account-reconcile that referenced this pull request Aug 8, 2024
@sergiobstoj @bencoronel
[UPD]account_statement_base: translation for PR OCA#659
8592e61
aritzolea pushed a commit to factorlibre/account-reconcile that referenced this pull request Sep 24, 2024
@sergiobstoj @aritzolea
[UPD]account_statement_base: translation for PR OCA#659
8573ad6
@sergiobstoj
Copy link
Member Author

@alexis-via is this OK for merge?

@pedrobaeza pedrobaeza added this to the 16.0 milestone Sep 27, 2024
pedrobaeza
pedrobaeza reviewed Sep 27, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduce the tests to one, as there's some duplication. Also remove trailing commas or use Command. for avoiding a lot of lines after the formater.

@pedrobaeza
Copy link
Member

Please solve the conflicts and squash both commits.

@sergiobstoj sergiobstoj force-pushed the 16.0-imp-account_statement_base-link_to_account_move_lines_from_statements branch 2 times, most recently from e8008ff to b27af85 Compare September 27, 2024 16:16
@sergiobstoj
[IMP] account_statement_base: add smart button on view_bank_statement…
b27af85 
…_form linking to journal items

[16.0][FIX] account_statement_base: Changes post OCA CR
pedrobaeza
pedrobaeza approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fw-port it to 17

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-659-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fb90476 into OCA:16.0 Sep 27, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ee3e8f0. Thanks a lot for contributing to OCA. ❤️

@sergiobstoj sergiobstoj mentioned this pull request Sep 27, 2024
Merged
@sergiobstoj sergiobstoj deleted the 16.0-imp-account_statement_base-link_to_account_move_lines_from_statements branch September 30, 2024 10:57
This was referenced Nov 14, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aritzolea aritzolea aritzolea approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sergiobstoj @OCA-git-bot @pedrobaeza @aritzolea