[16.0] [IMP] account_reconcile_oca: pass default name for lines created through reconciliation models #720
Conversation
|
Hi @etobella, |
|
Any screenshot of the before and after? |
@pedrobaeza ,consider a reconciliation model 'Test' as can be seen in following screenshot.There is no 'Journal Item Label' passed.
So currently, it passes a blank label on the reconciliation line when the reconciliation model is selected, as can be seen in the following screenshot.
After this PR,the default label(same as the label on the bank statement line) would be passed on the reconciliation line as can be seen in following screenshot
|
|
OK, understood. Thanks for the explanations. Please include that "Steps to reproduce the problem" in the commit message, omitting images, but explaining them by text. |
…the bank statement line) for lines created through reconciliation models if there is no 'Journal Item Label' passed in the reconciliation model
ByteMeAsap
force-pushed
the
16.0-imp-account_reconcile_oca-pass_default_name
branch
from
f4a1351 to
0b19dc3
Compare
@pedrobaeza ,done |
There was a problem hiding this comment.
Well, the commit message allows multiple lines, and the explanation should be put in consecutive lines, not everything in one line, but OK, I don't want to be more picky.
Please fw-port it to 17 using the expected commit message guidelines (with one first short line, and a detailed explanation in subsequent lines):
/ocabot merge patch
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at ba13d90. Thanks a lot for contributing to OCA. ❤️ |
This PR aims to pass a default name/label(same as the label on the bank statement line) for the new line that is created through reconciliation models if no label is passed through the reconciliation model