Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [ADD] partner_brand #162

Merged
merged 1 commit into from
Oct 12, 2023
Merged

[16.0] [ADD] partner_brand #162

merged 1 commit into from
Oct 12, 2023

Conversation

bealdav
Copy link
Member

@bealdav bealdav commented Apr 14, 2023 •
edited
Loading

Allow to set brand to partners allowing to group/filter partners by brand

A brand, here, could be Carrefour, Wallmart, etc.

It also display brand image in form view and flag for partner with brand in kanban

brand_form
brand_tree
brand_kanban

brand

I've made this module as custom one, do you think it can be useful here or with feature inside brand module

cc @sbejaoui @Rad0van @GSLabIt @andreampiovesana @ThomasBinsfeld

Other idea for this concept, but to implement in an other module, i.e. product_brand_pricelist :

  • define a pricelist to the partner (brand partner)
  • create a pricelist on each partner based on previous pricelist
  • or any suggestion ?

@bealdav bealdav marked this pull request as ready for review April 14, 2023 18:00
qtheuret
qtheuret suggested changes Apr 14, 2023
View reviewed changes
Copy link

@qtheuret qtheuret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fields.Image is not a related fields so we don't need this statement.

@bealdav bealdav requested a review from qtheuret April 15, 2023 11:08
@sbejaoui sbejaoui added this to the 16.0 milestone Apr 18, 2023
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

sbejaoui
sbejaoui approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@sbejaoui sbejaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review,

Just check the module name please

partner_brand/__manifest__.py Outdated Show resolved Hide resolved
@bealdav
Copy link
Member Author

bealdav commented Jul 5, 2023

@sbejaoui fixed. Could you merge ?

Thanks

@bosd
Copy link

bosd commented Aug 11, 2023

ping @sbejaoui :)

@bguillot
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-162-by-bguillot-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f6088b9 into OCA:16.0 Oct 12, 2023
4 of 5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8d19d2d. Thanks a lot for contributing to OCA. ❤️

@bealdav bealdav deleted the partner-brand branch October 12, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qtheuret qtheuret qtheuret approved these changes

@sbejaoui sbejaoui sbejaoui approved these changes

@PaulGoubert PaulGoubert PaulGoubert approved these changes

Assignees

@bealdav bealdav

Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
7 participants
@bealdav @OCA-git-bot @bosd @bguillot @qtheuret @sbejaoui @PaulGoubert