Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] brand #182

Merged
merged 79 commits into from
Nov 21, 2023
Merged

[17.0][MIG] brand #182

merged 79 commits into from
Nov 21, 2023

Conversation

AntoniRomera
Copy link

No description provided.

sbejaoui and others added 30 commits November 13, 2023 16:24
In a multi-company management system, there is a strong link between the company
and its brands. A company can't make sells under a brand that it don't own.
For this reason we add a mixin to be inherited from branded objects that assure the coherence of this link.

We also add an multi-company access rule for brand model.

A new field added to the company to define if the brand field is required or optional by company.
Co-Authored-By: Stéphane Bidoul (ACSONE) <stephane.bidoul@acsone.eu>
[UPD] README.rst
[UPD] Update brand.pot
In a multicompany scenario, a brand could invisibly be assigned to
the current company, preventing it from being shared with other
companies.

Exposing the Company field makes it easy for users to apply the
appropriate setting for their needs.
Co-Authored-By: Bhavesh Odedra <bodedra@opensourceintegrators.com>
[UPD] Update brand.pot
[ADD] - add sbejaoui as maintainer

[IMP] - move brand config section outside multi_company section

[FIX] - add brand_use_level to fields_view_get fields

[UPD] Update brand.pot

[UPD] README.rst

[UPD] Update brand.pot

[FIX] Fixed a travis.
[UPD] Update brand.pot

[UPD] README.rst
Translated using Weblate (French (France))

Currently translated at 100.0% (188 of 188 strings)

Translation: brand-14.0/brand-14.0-brand
Translate-URL: https://translation.odoo-community.org/projects/brand-14-0/brand-14-0-brand/fr_FR/

Added translation using Weblate (Italian)
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: brand-15.0/brand-15.0-brand
Translate-URL: https://translation.odoo-community.org/projects/brand-15-0/brand-15-0-brand/
ibuioli and others added 11 commits November 13, 2023 16:24
Currently translated at 100.0% (207 of 207 strings)

Translation: brand-16.0/brand-16.0-brand
Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-brand/es_AR/
Currently translated at 100.0% (207 of 207 strings)

Translation: brand-16.0/brand-16.0-brand
Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-brand/es/
Currently translated at 100.0% (207 of 207 strings)

Translation: brand-16.0/brand-16.0-brand
Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-brand/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: brand-16.0/brand-16.0-brand
Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-brand/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: brand-16.0/brand-16.0-brand
Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-brand/
Currently translated at 100.0% (226 of 226 strings)

Translation: brand-16.0/brand-16.0-brand
Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-brand/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: brand-16.0/brand-16.0-brand
Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-brand/
Currently translated at 100.0% (214 of 214 strings)

Translation: brand-16.0/brand-16.0-brand
Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-brand/es_AR/
@AntoniRomera AntoniRomera force-pushed the 17.0-mig-brand branch 2 times, most recently from 17b7408 to 8d5c12b Compare November 13, 2023 15:59
@AntoniRomera
Copy link
Author

@sbejaoui I have done the basic migration, can you check it?

Copy link

@MRomeera MRomeera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@FernandoRomera FernandoRomera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test in runboat, Ok.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Contributor

@sbejaoui sbejaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review

thanks

@sbejaoui
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-182-by-sbejaoui-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 415b87d into OCA:17.0 Nov 21, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f11b530. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.