Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] [17.0] base_phone #309

Closed
wants to merge 2 commits into from
Closed

Conversation

Nikul-OSI
Copy link

No description provided.

@Nikul-OSI Nikul-OSI force-pushed the 17_mig_nc_base_phone branch 3 times, most recently from fd30478 to b9cbdf7 Compare February 13, 2024 09:54
@Nikul-OSI Nikul-OSI marked this pull request as ready for review February 13, 2024 09:57
@Nikul-OSI
Copy link
Author

Hii @gurneyalex @alexis-via @PierrickBrun, Can you please review this PR?

@Nikul-OSI Nikul-OSI force-pushed the 17_mig_nc_base_phone branch 2 times, most recently from 05195d7 to 00ea03d Compare February 13, 2024 11:32
@Nikul-OSI Nikul-OSI mentioned this pull request Feb 13, 2024
2 tasks
@Nikul-OSI Nikul-OSI force-pushed the 17_mig_nc_base_phone branch from 00ea03d to 842b4ae Compare February 13, 2024 11:48
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionnal test on runboat,
LGTM
thanks for the migration

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 16, 2024
@pedrobaeza
Copy link
Member

Can you rebase and fix the conflicts?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 23, 2024
@flotho
Copy link
Member

flotho commented Jul 6, 2024

ping @Nikul-OSI any chance to follow @pedrobaeza recommendations ?
regards

@Nikul-OSI Nikul-OSI force-pushed the 17_mig_nc_base_phone branch from 842b4ae to 31597dd Compare July 8, 2024 04:34
@Nikul-OSI Nikul-OSI closed this Jul 8, 2024
@Nikul-OSI Nikul-OSI reopened this Jul 8, 2024
@Nikul-OSI
Copy link
Author

Already migrated #316

Closed

@Nikul-OSI Nikul-OSI closed this Jul 8, 2024
@OCA-git-bot
Copy link
Contributor

Hi @alexis-via,
some modules you are maintaining are being modified, check this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants