Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] product_import: currency can be implicit #1094

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from
Open

[14.0][IMP] product_import: currency can be implicit #1094

wants to merge 1 commit into from

Conversation

florentx
Copy link
Contributor

@florentx florentx commented Dec 9, 2024

When currency was not on each catalogue line, there was tons of warnings on importation.

twalter-c2c
twalter-c2c reviewed Dec 9, 2024
View reviewed changes
Copy link

@twalter-c2c twalter-c2c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks failed on NameError: name 'import_company_id' is not defined. Should it be product_company_id instead maybe?

@florentx florentx force-pushed the product_import_no_currency branch from 24e66d8 to c99b040 Compare December 9, 2024 14:31
@florentx florentx requested a review from twalter-c2c December 9, 2024 14:32
@florentx
Copy link
Contributor Author

florentx commented Dec 9, 2024

Fixed.

@florentx florentx force-pushed the product_import_no_currency branch from c99b040 to 4f3a811 Compare December 9, 2024 14:36
@florentx florentx force-pushed the product_import_no_currency branch from 4f3a811 to 71bb0b7 Compare December 10, 2024 08:57
@simahawk
Copy link
Contributor

A test would be nice... as usual 😉

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twalter-c2c twalter-c2c twalter-c2c approved these changes

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@florentx @simahawk @OCA-git-bot @twalter-c2c