Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] website_event_crm > website_event_crm_invitation: Migration to 15.0 #341

Merged
merged 11 commits into from
Sep 18, 2023

Conversation

chienandalu
Copy link
Member

  • Renaming of the module to avoid colission with the new core module of the same name (from v14)
  • Migration adaptations

cc @Tecnativa TT45105

please review @pedrobaeza @pilarvargas-tecnativa

Jairo Llopis and others added 10 commits September 15, 2023 13:46
This module lets you quickly invite customers to existing events on your
website, so they register themselves and remove some administrative
burden from your sales teams.

@Tecnativa TT27664

[UPD] Update website_event_crm.pot

[UPD] README.rst
The company field isn't mandatory for event types, so we have to check
that a lead auto invites to events available in the company of the lead.

We also have to check the proper base_url for our template. When we have
multi-website we want our customer going to the right link, otherwise
they'd be getting confusing info.

TT36027
When we send the invitation manually we don't have the proper context to
match the right url and get_base_url isn't very smart for this version.

TT37683
Currently translated at 100.0% (18 of 18 strings)

Translation: event-13.0/event-13.0-website_event_crm
Translate-URL: https://translation.odoo-community.org/projects/event-13-0/event-13-0-website_event_crm/it/
Currently translated at 100.0% (18 of 18 strings)

Translation: event-13.0/event-13.0-website_event_crm
Translate-URL: https://translation.odoo-community.org/projects/event-13-0/event-13-0-website_event_crm/it/
@pedrobaeza pedrobaeza changed the title [15.0][MIG] website_event_crm_invitation: Migration to 15.0 [15.0][MIG] website_event_crm > website_event_crm_invitation: Migration to 15.0 Sep 15, 2023
@pedrobaeza
Copy link
Member

/ocabot migration website_event_crm

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Sep 15, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 15, 2023
16 tasks
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenUpgrade should contain the renaming as well.

@chienandalu
Copy link
Member Author

OpenUpgrade should contain the renaming as well.

Should I do it in v14 or directly in v15?

@pedrobaeza
Copy link
Member

As website_event_crm exists already in 14.0: https://github.com/odoo/odoo/tree/14.0/addons/website_event_crm, it should be in OU 14

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember about the migration script for noupdate data.

@chienandalu chienandalu force-pushed the 15.0-mig-website_event_crm branch from b638e66 to dd13674 Compare September 15, 2023 16:33
@chienandalu
Copy link
Member Author

Remember about the migration script for noupdate data.

Yes, I'm working on it. I'm going to test it

@MiquelRForgeFlow
Copy link

Will this module be backported to v14?

@pedrobaeza
Copy link
Member

Not planned for now.

Copy link

@pilarvargas-tecnativa pilarvargas-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally reviewed, thanks

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-341-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1f5dfed into OCA:15.0 Sep 18, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0fd0ce3. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants