Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][BUG] fieldservice_account, total_cost raise error by some employee in timesheet #272

Closed
kittiu opened this issue Jul 7, 2019 · 0 comments
Assignees
Labels
Milestone

Comments

@kittiu
Copy link
Member

kittiu commented Jul 7, 2019

During writing test script I found following error when print order.total_cost

  File "/home/kittiu/ecosoft-odoo/field-service/fieldservice_account/models/fsm_order.py", line 52, in _compute_total_cost
    order.total_cost += line.unit_amount * rate
UnboundLocalError: local variable 'rate' referenced before assignment

Currently, we don't see the error on Work Order screen because,

  1. User may choose the employee with user_id, AND
  2. field "total_cost" is not show in the view, and so the method _compute_total_cost() is not called.

Steps to Error

  1. First, we need to modify view fieldservice_account.fsm_order_form_accounting to also show total_cost
  2. Create new Work Order, and select employee that has no user_id, i.e., Abigail Peterson
  3. Save it, and you will see the error.

Selection_145

Selection_146

@kittiu kittiu changed the title [12.0][BUG] fieldservice_account, _compute_total_cost raise error for some chosen employee in timesheet [12.0][BUG] fieldservice_account, total_cost raise error for some chosen employee in timesheet Jul 7, 2019
@kittiu kittiu changed the title [12.0][BUG] fieldservice_account, total_cost raise error for some chosen employee in timesheet [12.0][BUG] fieldservice_account, total_cost raise error by some employee in timesheet Jul 7, 2019
@max3903 max3903 added the bug label Jul 17, 2019
@max3903 max3903 added this to the 12.0 milestone Jul 17, 2019
osi-scampbell added a commit to ursais/field-service that referenced this issue Jul 18, 2019
osi-scampbell added a commit to ursais/field-service that referenced this issue Jul 18, 2019
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
OCA-git-bot pushed a commit that referenced this issue Aug 6, 2019
[IMP] Bug #265 Linked Location Search Error

[IMP] Bug #272 Rate Not Declared

[IMP] Bug #263 equipment_count Wrong

[IMP] Bug #277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
max3903 added a commit that referenced this issue Aug 6, 2019
@max3903 max3903 closed this as completed Aug 6, 2019
kongrattapong pushed a commit to ecosoft-odoo/field-service that referenced this issue Aug 21, 2019
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
kongrattapong pushed a commit to ecosoft-odoo/field-service that referenced this issue Aug 21, 2019
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
murtuzasaleh pushed a commit to SerpentConsultingServices/field-service that referenced this issue Feb 26, 2020
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
murtuzasaleh pushed a commit to SerpentConsultingServices/field-service that referenced this issue Mar 16, 2020
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
brian10048 pushed a commit to brian10048/field-service that referenced this issue Jul 20, 2020
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
brian10048 pushed a commit to brian10048/field-service that referenced this issue Nov 11, 2020
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
Murtaza-OSI pushed a commit to ursais/field-service that referenced this issue Jan 18, 2021
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
Khalid-SerpentCS pushed a commit to ursais/field-service that referenced this issue Jan 19, 2021
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
Freni-OSI pushed a commit to ursais/field-service that referenced this issue Jan 27, 2021
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
Freni-OSI pushed a commit to ursais/field-service that referenced this issue Feb 11, 2021
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
hparfr pushed a commit to akretion/field-service that referenced this issue Mar 11, 2021
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
hparfr pushed a commit to akretion/field-service that referenced this issue Mar 11, 2021
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
Freni-OSI pushed a commit to ursais/field-service that referenced this issue Mar 18, 2021
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
Freni-OSI pushed a commit to ursais/field-service that referenced this issue Apr 14, 2021
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
Freni-OSI pushed a commit to ursais/field-service that referenced this issue Apr 19, 2021
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
baimont pushed a commit to acsone/field-service that referenced this issue Apr 22, 2021
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
Vimal-OSI pushed a commit to ursais/field-service that referenced this issue Jul 13, 2021
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
Vimal-OSI pushed a commit to ursais/field-service that referenced this issue Jul 13, 2021
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
patrickrwilson pushed a commit to ursais/field-service that referenced this issue Jul 13, 2021
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
AmmarOfficewalaSerpentCS pushed a commit to ursais/field-service that referenced this issue Jan 7, 2022
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
Vandan-OSI pushed a commit to ursais/field-service that referenced this issue Jan 7, 2022
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
Murtaza-OSI pushed a commit to ursais/field-service that referenced this issue Apr 6, 2022
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
Freni-OSI pushed a commit to ursais/field-service that referenced this issue Apr 6, 2022
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
victoralmau pushed a commit to Tecnativa/field-service that referenced this issue Aug 8, 2022
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
victoralmau pushed a commit to Tecnativa/field-service that referenced this issue Aug 9, 2022
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
victoralmau pushed a commit to Tecnativa/field-service that referenced this issue Oct 5, 2022
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
max3903 pushed a commit to ursais/field-service that referenced this issue Oct 10, 2022
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
max3903 pushed a commit to ursais/field-service that referenced this issue Oct 10, 2022
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
Freni-OSI pushed a commit to ursais/field-service that referenced this issue Oct 19, 2022
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
Freni-OSI pushed a commit to ursais/field-service that referenced this issue Oct 27, 2022
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
ghost pushed a commit to gbrito/field-service that referenced this issue Oct 28, 2022
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
ShwetaSerpentCS pushed a commit to ShwetaSerpentCS/field-service that referenced this issue Oct 28, 2022
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
ghost pushed a commit to gbrito/field-service that referenced this issue Nov 8, 2022
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
epanisset pushed a commit to camptocamp/field-service that referenced this issue Jan 30, 2023
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
brian10048 pushed a commit to brian10048/field-service that referenced this issue Nov 15, 2023
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
brian10048 pushed a commit to brian10048/field-service that referenced this issue Nov 17, 2023
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
brian10048 pushed a commit to brian10048/field-service that referenced this issue Nov 27, 2023
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
SMaciasOSI pushed a commit to ursais/field-service that referenced this issue Dec 19, 2023
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
EdgarRetes pushed a commit to ursais/field-service that referenced this issue Oct 8, 2024
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
EdgarRetes pushed a commit to ursais/field-service that referenced this issue Oct 15, 2024
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
EdgarRetes pushed a commit to ursais/field-service that referenced this issue Oct 23, 2024
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
EdgarRetes pushed a commit to ursais/field-service that referenced this issue Oct 30, 2024
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
EdgarRetes pushed a commit to ursais/field-service that referenced this issue Oct 30, 2024
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants