[ADD] Vehicle #23
[ADD] Vehicle #23
Conversation
|
Hey @brian10048, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
|
Thanks @brian10048. Nice work! Let me know if you need help signing the CLA and fixing Travis errors. |
access rights for Vehicle, other Travis errors
|
Glad to be a part @max3903 I emailed my signed CLA with GitHub login yesterday once the comment was posted here. Looks like Travis errors are good now as well! |
|
@brian10048 I processed your CLA. 👍 |
|
I am probably late, but why are you adding vehicles on the main module? IMHO, it should be made modular. So if a company has vehicles, it should be added as a new module. If all is added on the same module, you may have all functionality but in some cases only 30% is used |
|
The future module The idea is to provide the basic features with settings in a single module, and advanced ones with additional modules. |
|
Vehicles should not be a basic feature. On your documents, you expected to add features for even doctors, but they usually don't use vehicles. I think the main module should have the service order and all the shared models. All the other models should be added on new modules. |
|
Vehicle feature is only visible if you activate it in the settings, like invoicing vs accounting or product template vs variants. |
|
The vehicle features are hidden by default in the core module and require
no additional dependencies
The nature of field service would most of the time require that you use a
vehicle to travel to the location being serviced. If one doesn't need to
track vehicle data, the feature can remain off.
|
|
Yes, I know, but you are adding unnecessary features on the initial module. That is what i mean. |
[ADD] fieldservice 0.0.1 (#2) [UPD] addons table in README.md [ci skip] [UPD] README.rst [ADD] setup.py REDCOR.md should list redcor enhancements [IMP] README: explain what is FSM [ADD] Vehicle (OCA#23) * [ADD] Vehicle [OCA]12567 Location structure needs to reflect hierarchy of Buildings (OCA#22) * [IMP] Extend fsm.location object [UPD] README.rst [FIX] View [ADD] red_fsm base, team handler Option for enabling the red_fsm teams, new mwnu added under fieldservice settings to use red_fsm teams. Removed incomplete method [ADD] stages and stage sets add website_support module change module structure [removed] remove website_support module, modified labels for fields and menu modifications, cleaned code Advanced stage transitions, option to add stage transitions for the stage sets Tickets base. Support ticket base form, mail notification to employees and customers, etc team: basic skills, person basic skills. Tickets: ticket from website adjusted indentation added plone code as a sample team handler
* [ADD] Vehicle
|
Hey @brian10048, Appreciation of efforts, |
* [ADD] Vehicle
[IMP] Fix Travis Redlight
* [ADD] Vehicle
* [ADD] Vehicle
* [ADD] Vehicle
* [ADD] Vehicle
* [ADD] Vehicle
* [ADD] Vehicle
* [ADD] Vehicle
* [ADD] Vehicle
* [ADD] Vehicle
* [ADD] Vehicle
* [ADD] Vehicle
Is this what is needed for #4 ?
Still need to add some reporting features