[13.0] [MIG] fieldservice_account #598

brian10048 · 2020-07-20T17:24:39Z

Migration of fieldservice_account to 13.0

#354

OCA-git-bot · 2020-07-20T17:24:44Z

Hi @bodedra, @osimallen,
some modules you are maintaining are being modified, check this out!

brian10048 · 2020-07-20T20:43:13Z

💚 This one is ready for functional testing

brian10048 · 2020-07-20T20:52:33Z

@max3903

Do we need a migration script for the accounting model changes?
Can I delete the 12.0 migration script?

RLeeOSI · 2020-10-07T22:18:20Z

fieldservice_account/tests/test_fsm_account.py

+                "email": "tp@email.com",
+                "partner_id": self.test_loc_partner.id,
+                "owner_id": self.test_loc_partner.id,
+                "customer_id": self.test_loc_partner.id,


Suggested change

"customer_id": self.test_loc_partner.id,

customer_id was moved to fieldservice_account_analytic

Good catch @RLeeOSI

I'll take care of that.

Do you have any thoughts about my questions here: #598 (comment)?

Yes, a migration script is needed. However, the v13 account migration is not done yet (see the latest here) so it might be best to put that on hold for now. According to the maintainer guide all old migration scripts should be removed

max3903 · 2020-10-15T14:22:41Z

@brian10048

Do we need a migration script for the accounting model changes?

Yes

Can I delete the 12.0 migration script?

You can, but I am not sure you need to.

bodedra

Change file name as well.

fieldservice_account/models/__init__.py

brian10048 · 2020-10-22T00:38:39Z

Migration script added

Currently translated at 100.0% (9 of 9 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_account Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_account/es/

Currently translated at 44.4% (4 of 9 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_account Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_account/it/

Currently translated at 100.0% (9 of 9 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_account Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_account/pt_BR/

hparfr · 2020-11-11T20:58:46Z

Hi Brian, please have a look to brian10048#19

bodedra · 2020-11-17T03:49:33Z

@hparfr I have commented brian10048#19 (comment) in your PR.

CC @max3903

hparfr · 2021-01-15T09:48:26Z

@brian10048 can you please review brian10048#19 ?

marcelsavegnago

LGTM

OCA-git-bot · 2021-01-15T16:56:27Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

brian10048 · 2021-01-15T20:43:11Z

@max3903 @dreispt Are either of you able to review this PR and sign off on the v13 migration for fieldservice_account? We would greatly appreciate it!

hparfr · 2021-02-11T20:28:01Z

Can we merge this PR? I plan to work on v14 port soon.

brian10048 · 2021-02-12T19:11:39Z

/ocabot merge nobump

OCA-git-bot · 2021-02-12T19:11:57Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-598-by-brian10048-bump-nobump, awaiting test results.

OCA-git-bot · 2021-02-12T20:48:19Z

Congratulations, your PR was merged at 2dc97f4. Thanks a lot for contributing to OCA. ❤️

brian10048 added needs review migration labels Jul 20, 2020

brian10048 added this to the 13.0 milestone Jul 20, 2020

brian10048 requested review from max3903, marcelsavegnago, nelsonramirezs and bodedra July 20, 2020 17:24

brian10048 self-assigned this Jul 20, 2020

OCA-git-bot mentioned this pull request Jul 20, 2020

Migration to version 13.0 #354

Open

43 tasks

brian10048 mentioned this pull request Jul 20, 2020

[13.0] [MIG] fieldservice_sale #595

Merged

brian10048 force-pushed the 13.0-mig-fsm-account branch 4 times, most recently from e44abf7 to 799713c Compare July 20, 2020 19:34

brian10048 linked an issue Jul 20, 2020 that may be closed by this pull request

Migration to version 13.0 #354

Open

43 tasks

brian10048 force-pushed the 13.0-mig-fsm-account branch 2 times, most recently from 0ee9d40 to 3f60c3e Compare July 20, 2020 20:25

brian10048 mentioned this pull request Aug 2, 2020

13.0 #610

Closed

brian10048 requested a review from RLeeOSI October 6, 2020 00:02

murtuzasaleh mentioned this pull request Oct 6, 2020

[13.0][MIG] fieldservice_account_analytic #650

Closed

RLeeOSI reviewed Oct 7, 2020

View reviewed changes

bodedra reviewed Oct 16, 2020

View reviewed changes

fieldservice_account/models/__init__.py Outdated Show resolved Hide resolved

fieldservice_account/models/__init__.py Outdated Show resolved Hide resolved

brian10048 force-pushed the 13.0-mig-fsm-account branch from 3f60c3e to 84047aa Compare October 22, 2020 00:37

brian10048 force-pushed the 13.0-mig-fsm-account branch 2 times, most recently from 0428254 to 5c80498 Compare October 22, 2020 01:05

Nelson Ramírez Sánchez and others added 6 commits November 10, 2020 20:58

Translated using Weblate (Spanish)

be38a9a

Currently translated at 100.0% (9 of 9 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_account Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_account/es/

Added translation using Weblate (Italian)

d854aec

Translated using Weblate (Italian)

86860fc

Currently translated at 44.4% (4 of 9 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_account Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_account/it/

[IMP] fieldservice_account: black, isort, prettier

c044f2e

[MIG] fieldservice_account: Migration to 13.0

caa5bbb

brian10048 force-pushed the 13.0-mig-fsm-account branch from c4feb5e to caa5bbb Compare November 11, 2020 01:58

brian10048 requested a review from hparfr November 11, 2020 02:01

hparfr and others added 2 commits January 15, 2021 10:03

fieldservice_account fix relation between fsm_order and invoice_line

ae1fb3b

[IMP] fieldservice_account: pre-commit

327d32b

brian10048 force-pushed the 13.0-mig-fsm-account branch from 78603fb to 327d32b Compare January 15, 2021 15:29

hparfr approved these changes Jan 15, 2021

View reviewed changes

OCA-git-bot added the approved label Jan 15, 2021

marcelsavegnago approved these changes Jan 15, 2021

View reviewed changes

brian10048 requested a review from dreispt January 15, 2021 16:18

OCA-git-bot added the ready to merge label Jan 15, 2021

brian10048 mentioned this pull request Jan 16, 2021

[13.0] [MIG] fieldservice_account_payment #691

Closed

OCA-git-bot added the bot is merging ⏳ label Feb 12, 2021

OCA-git-bot merged commit baec233 into OCA:13.0 Feb 12, 2021

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Feb 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[13.0] [MIG] fieldservice_account #598

[13.0] [MIG] fieldservice_account #598

brian10048 commented Jul 20, 2020

OCA-git-bot commented Jul 20, 2020

brian10048 commented Jul 20, 2020

brian10048 commented Jul 20, 2020

RLeeOSI Oct 7, 2020

brian10048 Oct 7, 2020

RLeeOSI Oct 7, 2020 •

edited

Loading

max3903 commented Oct 15, 2020

bodedra left a comment

brian10048 commented Oct 22, 2020

hparfr commented Nov 11, 2020

bodedra commented Nov 17, 2020

hparfr commented Jan 15, 2021

marcelsavegnago left a comment

OCA-git-bot commented Jan 15, 2021

brian10048 commented Jan 15, 2021

hparfr commented Feb 11, 2021

brian10048 commented Feb 12, 2021

OCA-git-bot commented Feb 12, 2021

OCA-git-bot commented Feb 12, 2021

[13.0] [MIG] fieldservice_account #598

[13.0] [MIG] fieldservice_account #598

Conversation

brian10048 commented Jul 20, 2020

OCA-git-bot commented Jul 20, 2020

brian10048 commented Jul 20, 2020

brian10048 commented Jul 20, 2020

RLeeOSI Oct 7, 2020

Choose a reason for hiding this comment

brian10048 Oct 7, 2020

Choose a reason for hiding this comment

RLeeOSI Oct 7, 2020 • edited Loading

Choose a reason for hiding this comment

max3903 commented Oct 15, 2020

bodedra left a comment

Choose a reason for hiding this comment

brian10048 commented Oct 22, 2020

hparfr commented Nov 11, 2020

bodedra commented Nov 17, 2020

hparfr commented Jan 15, 2021

marcelsavegnago left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jan 15, 2021

brian10048 commented Jan 15, 2021

hparfr commented Feb 11, 2021

brian10048 commented Feb 12, 2021

OCA-git-bot commented Feb 12, 2021

OCA-git-bot commented Feb 12, 2021

RLeeOSI Oct 7, 2020 •

edited

Loading