Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] fieldservice_stage_server_action: Remove dependency #605

Merged
merged 1 commit into from
Jul 29, 2020
Merged

[IMP] fieldservice_stage_server_action: Remove dependency #605

merged 1 commit into from
Jul 29, 2020

Conversation

brian10048
Copy link
Contributor

This module depended on fieldservice_substatus only so it could inherit an inherited view. This removes that dependency and directly inherits the base view for FSM Stage

@brian10048
[IMP] fieldservice_stage_server_action: Remove dependency
bb4bc73 
This module depended on fieldservice_substatus only so it could inherit an inherited view.  This removes that dependency and directly inherits the base view for FSM Stage
@brian10048 brian10048 added this to the 12.0 milestone Jul 21, 2020
@brian10048 brian10048 self-assigned this Jul 21, 2020
@OCA-git-bot
Copy link
Contributor

Hi @wolfhall, @max3903, @osi-scampbell,
some modules you are maintaining are being modified, check this out!

@brian10048 brian10048 mentioned this pull request Jul 21, 2020
Merged
bodedra
bodedra approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@bodedra bodedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

patrickrwilson
patrickrwilson approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@patrickrwilson patrickrwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@brian10048
Copy link
Contributor Author

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-605-by-brian10048-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2afb48b into OCA:12.0 Jul 29, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at dedbf1f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@bodedra bodedra bodedra approved these changes

@patrickrwilson patrickrwilson patrickrwilson approved these changes

@max3903 max3903 Awaiting requested review from max3903

@nelsonramirezs nelsonramirezs Awaiting requested review from nelsonramirezs

@osi-scampbell osi-scampbell Awaiting requested review from osi-scampbell

Assignees

@brian10048 brian10048

Labels
approved enhancement merged 🎉 needs review ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@brian10048 @OCA-git-bot @marcelsavegnago @bodedra @patrickrwilson