Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] [MIG] fieldservice_location_builder #704

Merged
merged 19 commits into from
Nov 10, 2022
Merged

[14.0] [MIG] fieldservice_location_builder #704

merged 19 commits into from
Nov 10, 2022

Conversation

Murtaza-OSI
Copy link
Contributor

No description provided.

@Murtaza-OSI Murtaza-OSI changed the title 14.0 mig fieldservice location builder [14.0] [MIG] fieldservice_location_builder Jan 19, 2021
@brian10048 brian10048 added this to the 14.0 milestone Jan 19, 2021
@brian10048 brian10048 mentioned this pull request Jan 19, 2021
Open
43 tasks
@Murtaza-OSI Murtaza-OSI force-pushed the 14.0-MIG-fieldservice_location_builder branch from ba60e7e to 9f5361e Compare March 18, 2021 12:00
@dreispt dreispt force-pushed the 14.0-MIG-fieldservice_location_builder branch 3 times, most recently from 190bfad to d45fe97 Compare December 10, 2021 16:00
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 14, 2022
@github-actions github-actions bot closed this Sep 18, 2022
@brian10048 brian10048 added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed Blocked by dependency stale PR/Issue without recent activity, it'll be soon closed automatically. labels Nov 2, 2022
@brian10048 brian10048 reopened this Nov 2, 2022
osi-scampbell and others added 11 commits November 10, 2022 12:52
@osi-scampbell @Freni-OSI
[ADD] fieldservice_location_builder
c0577f3
@oca-travis @Freni-OSI
[UPD] Update fieldservice_location_builder.pot
f3c5184
@OCA-git-bot @Freni-OSI
[UPD] README.rst
3bae5c3
@Freni-OSI
Added translation using Weblate (Spanish (Chile))
bb8ccee
@Freni-OSI
Translated using Weblate (Spanish (Chile))
d7bf608 
Currently translated at 77.3% (17 of 22 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_location_builder
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_location_builder/es_CL/
@marylla @Freni-OSI
Added translation using Weblate (German)
2e33c89
@marylla @Freni-OSI
Translated using Weblate (German)
d5f6263 
Currently translated at 4.5% (1 of 22 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_location_builder
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_location_builder/de/
@marylla @Freni-OSI
Translated using Weblate (German)
e5cebf0 
Currently translated at 31.8% (7 of 22 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_location_builder
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_location_builder/de/
@marylla @Freni-OSI
Translated using Weblate (German)
d8a60e8 
Currently translated at 40.9% (9 of 22 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_location_builder
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_location_builder/de/
@marcelsavegnago @Freni-OSI
Added translation using Weblate (Portuguese (Brazil))
93e4b4f
@max3903 @Freni-OSI
[ADD] Spanish (es) translation
c7a44b2
@Freni-OSI Freni-OSI force-pushed the 14.0-MIG-fieldservice_location_builder branch from d45fe97 to b09024c Compare November 10, 2022 07:25
@chienandalu
Copy link
Member

It still has a hidden dependency. Following my tip, you can work around it without changing your code logic too much

chienandalu
chienandalu approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙂 👍

@Freni-OSI Freni-OSI force-pushed the 14.0-MIG-fieldservice_location_builder branch from 1f493e2 to f95af22 Compare November 10, 2022 10:30
@Freni-OSI Freni-OSI force-pushed the 14.0-MIG-fieldservice_location_builder branch from f95af22 to 300b368 Compare November 10, 2022 10:46
@Freni-OSI
Copy link
Contributor

@pedrobaeza @max3903 It's ready for review

@max3903
Copy link
Member

max3903 commented Nov 10, 2022

/ocabot migration fieldservice_location_builder

@max3903
Copy link
Member

max3903 commented Nov 10, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-704-by-max3903-bump-nobump, awaiting test results.

@max3903 max3903 added needs review and removed bot is merging ⏳ no stale Use this label to prevent the automated stale action from closing this PR/Issue. labels Nov 10, 2022
@max3903 max3903 assigned max3903 and unassigned Murtaza-OSI Nov 10, 2022
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit f20f85d into OCA:14.0 Nov 10, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at eaf3b23. Thanks a lot for contributing to OCA. ❤️

@max3903 max3903 deleted the 14.0-MIG-fieldservice_location_builder branch November 10, 2022 14:05
@max3903 max3903 restored the 14.0-MIG-fieldservice_location_builder branch November 10, 2022 14:38
@max3903 max3903 deleted the 14.0-MIG-fieldservice_location_builder branch November 10, 2022 14:38
@Freni-OSI Freni-OSI mentioned this pull request Nov 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

@max3903 max3903 max3903 approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees

@max3903 max3903

Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.