Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] fieldservice_account_analytic #773

Closed
wants to merge 39 commits into from

Conversation

baimont
Copy link

@baimont baimont commented Apr 28, 2021

#354

Hi there,
I know @murtuzasaleh already did a fine job there #650.
But I was trying to migrate fieldservice_isp_account which depends on fieldservice_account_analytic... And I had a problem with unit tests.
Tests on #650 are not working because they depend on fieldservice_account's setUp() which creates test_location without customer_id. And since customer_id becomes required with fieldservice_account_analytic, the test doesn't go further. I propose here to solve this by removing the dependency on fieldservice_account for fieldservice_account_analytic tests.

brian10048 and others added 30 commits April 28, 2021 15:27
- This change removes most of the invoicing logic from fieldservice_account and puts it into its own module
Currently translated at 11.1% (2 of 18 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_account_analytic
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_account_analytic/es_CL/
[IMP] Move Method Up

[IMP] api.model + space

[IMP] fsm_parent_id

[FIX] Typo
Currently translated at 100.0% (18 of 18 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_account_analytic
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_account_analytic/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-12.0/field-service-12.0-fieldservice_account_analytic
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_account_analytic/
Currently translated at 100.0% (17 of 17 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_account_analytic
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_account_analytic/pt_BR/
[IMP] Remove Unused Import

[IMP] Github Comments

[IMP] Add FSM to Variable
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-12.0/field-service-12.0-fieldservice_account_analytic
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_account_analytic/
Currently translated at 100.0% (21 of 21 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_account_analytic
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_account_analytic/pt_BR/
Currently translated at 100.0% (21 of 21 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_account_analytic
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_account_analytic/pt_BR/
@baimont baimont force-pushed the 13.0-mig-fieldservice_account_analytic branch 3 times, most recently from c8d56b4 to b5f8dbb Compare May 7, 2021 06:02
.travis.yml Outdated
@@ -24,6 +23,9 @@ jobs:
- stage: linting
name: "pre-commit"
before_install:
- sudo add-apt-repository -y "deb https://apt-archive.postgresql.org/pub/repos/apt trusty-pgdg-archive main"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

about this : postgis doesn't seem to be installable on trusty anymore.
https://www.postgresql.org/message-id/YBMtd6nRuXyU2zS4%40msg.df7cb.de

@sbidoul
Copy link
Member

sbidoul commented May 10, 2021

Hi @moylop260, my colleage @baimont is are trying to make this repo work on runbot.

The problem is that the vauxoo/odoo-80-image-shippable-auto that is used on runbot is based on Ubuntu 14 trusty and postgis is not easily available for that old OS anymore. Do you know if we can use another docker image on runbot, ideally based on an ubuntu version that is available on travis too ?

@moylop260
Copy link

HI @sbidoul

We need to work to use a new image

But I'm not able to do it right now

This is the project related with that image:

It needs multi-python version in order to support to choose one

Maybe using a newer image and using pyenv could be a good approach

@sbidoul
Copy link
Member

sbidoul commented May 11, 2021

Hi @moylop260 thanks for the explanation. It is probably not worth putting effort into this now, as we still plan to move to GitHub actions and the new runbot.

@brian10048 brian10048 added this to the 13.0 milestone May 12, 2021
@baimont baimont force-pushed the 13.0-mig-fieldservice_account_analytic branch from cae2374 to 2eb1906 Compare May 20, 2021 17:56
@baimont baimont force-pushed the 13.0-mig-fieldservice_account_analytic branch from 2eb1906 to b5a4e9e Compare May 27, 2021 08:06
@baimont baimont force-pushed the 13.0-mig-fieldservice_account_analytic branch from dd05002 to 1a2a9fb Compare June 17, 2021 08:45
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 25, 2022
@github-actions github-actions bot closed this Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.