Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP]l10n_it_ricevute_bancarie:Wizard per filtrare riba in base all'ammontare massimo #3411

Merged
merged 1 commit into from
Sep 18, 2023
Merged

[14.0][IMP]l10n_it_ricevute_bancarie:Wizard per filtrare riba in base all'ammontare massimo #3411

merged 1 commit into from
Sep 18, 2023

Conversation

odooNextev
Copy link
Contributor

@odooNextev odooNextev commented Jun 27, 2023 •
edited
Loading

La voce di menù 'Presentazione Riba' permette estrarre le riba fino al raggiungimento dell'importo massimo inserito dall'utente.

@odooNextev odooNextev force-pushed the 14.0-imp-l10n_it_ricevute_bancarie branch from 5eaac49 to 524addc Compare June 27, 2023 08:50
@odooNextev odooNextev changed the title [IMP]Wizard per filtrare riba in base all'ammontare massimo [14.0][IMP]l10n_it_ricevute_bancarie:Wizard per filtrare riba in base all'ammontare massimo Jun 27, 2023
stefano-ooops
stefano-ooops approved these changes Jul 26, 2023
View reviewed changes
Copy link

@stefano-ooops stefano-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test ok

@francesco-ooops
Copy link
Contributor

@OCA/local-italy-maintainers opinioni?

@francesco-ooops
Copy link
Contributor

@odooNextev potete squashare e rinominare i commit? grazie

@odooNextev odooNextev force-pushed the 14.0-imp-l10n_it_ricevute_bancarie branch from 20bc845 to bf4f721 Compare July 28, 2023 07:58
@odooNextev odooNextev force-pushed the 14.0-imp-l10n_it_ricevute_bancarie branch from 063a7c0 to 3054b1c Compare August 4, 2023 11:50
aleuffre
aleuffre approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giusto una piccola nota che non compromette comunque il funzionamento.

Code review 👍

l10n_it_ricevute_bancarie/wizard/wizard_presentation_riba.py Outdated
Comment on lines 32 to 34
if line.amount_residual < self.presentation_amount:
self.presentation_amount -= line.amount_residual
list_ids.append(line.id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if line.amount_residual < self.presentation_amount:
self.presentation_amount -= line.amount_residual
list_ids.append(line.id)
if line.amount_residual > self.presentation_amount:
break
self.presentation_amount -= line.amount_residual
list_ids.append(line.id)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della review. Ho pubblicato la modifica suggerita

@odooNextev odooNextev force-pushed the 14.0-imp-l10n_it_ricevute_bancarie branch from 3054b1c to 019c82a Compare August 4, 2023 13:36
TheMule71
TheMule71 reviewed Aug 4, 2023
View reviewed changes
l10n_it_ricevute_bancarie/wizard/wizard_presentation_riba.py Outdated
],
order="date_maturity asc, price_total asc",
):
if line.amount_residual > self.presentation_amount:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ciao, se devi confrontare importi, meglio usare i metodi del modello res.currency se nel model c'è un currency_id oppure le funzioni per i float nelle utils.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie del consiglio. Ho aggiornato la pr utilizzando il float_compare

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheMule71 buona ora? :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

io userei direttamente:

https://github.com/odoo/odoo/blob/b95770a5f20de994bc7136b46c9a4541f523aae6/odoo/addons/base/models/res_currency.py#L143

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheMule71 ho visto che la tua richiesta è stata applicata 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@odooNextev odooNextev force-pushed the 14.0-imp-l10n_it_ricevute_bancarie branch 2 times, most recently from ff7579c to f711806 Compare August 7, 2023 10:17
@francesco-ooops
Copy link
Contributor

@TheMule71 buona per il merge? :)

@francesco-ooops
Copy link
Contributor

@OCA/local-italy-maintainers possiamo procedere? grazie!

@francesco-ooops
Copy link
Contributor

@OCA/local-italy-maintainers merge?

@francesco-ooops
Copy link
Contributor

@tafaRU @TheMule71 @eLBati gentilmente :)

@odooNextev odooNextev force-pushed the 14.0-imp-l10n_it_ricevute_bancarie branch from f711806 to be0f220 Compare September 18, 2023 07:03
@tafaRU
Copy link
Member

tafaRU commented Sep 18, 2023

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-3411-by-tafaRU-bump-minor, awaiting test results.

@francesco-ooops francesco-ooops mentioned this pull request Sep 18, 2023
Closed
@OCA-git-bot OCA-git-bot merged commit 89831ec into OCA:14.0 Sep 18, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f5b077c. Thanks a lot for contributing to OCA. ❤️

@francesco-ooops francesco-ooops mentioned this pull request Nov 24, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francesco-ooops francesco-ooops francesco-ooops left review comments

@TheMule71 TheMule71 TheMule71 left review comments

@stefano-ooops stefano-ooops stefano-ooops approved these changes

@aleuffre aleuffre aleuffre approved these changes

@GSLabIt GSLabIt GSLabIt approved these changes

@tafaRU tafaRU tafaRU approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 missing issue ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@odooNextev @francesco-ooops @OCA-git-bot @tafaRU @TheMule71 @GSLabIt @aleuffre @stefano-ooops @matteonext