[MIG] l10n_it_ricevute_bancarie -> l10n_it_riba #3615

SirAionTech · 2023-09-28T12:55:20Z

Sostituisce #3131.

Ho lasciato alcune modifiche in un commit separato perché applicabili anche a 14.0, nel caso qualcuno volesse cimentarsi.

Risolve #3616 per 16.0.

moving from https://code.launchpad.net/~openobject-italia-core-devs/openobject-italia/l10n_it_ricevute_bancarie

…_jasper

Changes for 6.0 should be done in a branch for 6.0. For the reason to use 'fields.date' instead of 'time', see https://bugs.launchpad.net/openobject-server/+bug/925361 https://bugs.launchpad.net/openerp-web/+bug/918257

…ect-italia/adding_riba_v7/+merge/194620/comments/449412

and valueerror

Moving to lp:~agilebg/openobject-italia/riba_v7_style

… wizard export riba

…ri in wizard export

…ione, data di registrazione su distinta

moves all modules into a __unported__ directory

'Technical method to migrate a module from "8.0" to "10.0" branch' gives too many conflicts

porting to new API porting to new accounting porting views porting tests FIX l10n_it_ricevute_bancarie wrong computation of payment_ids and tests ADD OCA dep for account_due_list

…t as default for action_riba_da_emettere

debit bank is not mandatory in CBI file From documentation: 2.7 Struttura del record - codice fisso “40” 71-120 f an Banca/sportello domiciliataria F eventuale denominazione in chiaro della banca/sportello domiciliataria/o;

…A#321)

after odoo/odoo@efa4f85 otherwise: 2017-05-20 03:21:02,605 6389 ERROR openerp_test odoo.addons.l10n_it_ricevute_bancarie.tests.test_riba: ERROR: test_delete_due_cost_line (odoo.addons.l10n_it_ricevute_bancarie.tests.test_riba.TestInvoiceDueCost) 2017-05-20 03:21:02,605 6389 ERROR openerp_test odoo.addons.l10n_it_ricevute_bancarie.tests.test_riba: Traceback (most recent call last): 2017-05-20 03:21:02,605 6389 ERROR openerp_test odoo.addons.l10n_it_ricevute_bancarie.tests.test_riba: ` File "/home/travis/build/OCA/l10n-italy/l10n_it_ricevute_bancarie/tests/test_riba.py", line 205, in test_delete_due_cost_line 2017-05-20 03:21:02,605 6389 ERROR openerp_test odoo.addons.l10n_it_ricevute_bancarie.tests.test_riba: ` self.invoice.action_invoice_draft() 2017-05-20 03:21:02,606 6389 ERROR openerp_test odoo.addons.l10n_it_ricevute_bancarie.tests.test_riba: ` File "/home/travis/build/OCA/l10n-italy/l10n_it_ricevute_bancarie/models/account/account.py", line 213, in action_invoice_draft 2017-05-20 03:21:02,606 6389 ERROR openerp_test odoo.addons.l10n_it_ricevute_bancarie.tests.test_riba: ` line.unlink() 2017-05-20 03:21:02,606 6389 ERROR openerp_test odoo.addons.l10n_it_ricevute_bancarie.tests.test_riba: ` File "/home/travis/odoo-10.0/addons/account/models/account_invoice.py", line 1360, in unlink 2017-05-20 03:21:02,606 6389 ERROR openerp_test odoo.addons.l10n_it_ricevute_bancarie.tests.test_riba: ` raise UserError(_('You can only delete an invoice line if the invoice is in draft state.')) 2017-05-20 03:21:02,606 6389 ERROR openerp_test odoo.addons.l10n_it_ricevute_bancarie.tests.test_riba: ` UserError: (u'You can only delete an invoice line if the invoice is in draft state.', None)

File "odoo/lib/python2.7/site-packages/odoo/models.py", line 4369, in <lambda> @api.returns('self', lambda value: value.id) AttributeError: 'NoneType' object has no attribute 'id' while duplicating

TonyMasciI · 2023-10-05T08:29:30Z

l10n_it_riba/views/account_view.xml

-    <record id="view_account_invoice_filter_unsolved" model="ir.ui.view">
-        <field name="name">account.invoice.select.unsolved</field>
+    <record id="view_account_invoice_filter_past_due" model="ir.ui.view">
+        <field name="name">account.invoice.select.past_due</field>
        <field name="model">account.move</field>
        <field name="inherit_id" ref="account.view_account_invoice_filter"/>
        <field name="arch" type="xml">
            <filter name="unpaid" position="after">
-               <filter name="unsolved" string="Past Due" domain="[('is_unsolved','=',True)]" help="Past Due Invoices"/>
+               <filter name="past_due" string="Past Due" domain="[('is_past_due','=',True)]" help="Past Due Invoices"/>
            </filter>
        </field>
    </record>


Se non serve eliminare

TonyMasciI · 2023-10-05T08:29:44Z

l10n_it_riba/views/account_view.xml

            <!-- MABO
            <field name="tax_ids" position="after">
-                <field name="unsolved_move_line_ids" colspan="4" nolabel="1"/>
+                <field name="past_due_move_line_ids" colspan="4" nolabel="1"/>
            </field>
            -->


Se non serve Eliminare

Migration scripts not tested because `account` module cannot be migrated yet with OpenUpgrade Co-authored-by: Tony Masci <45100916+TonyMasciI@users.noreply.github.com>

Cleanup old syntax super(Class, instance) -> super() Remove unused code

andreampiovesana

LGTM functional review

eLBati · 2023-10-05T15:41:34Z

/ocabot merge nobump

OCA-git-bot · 2023-10-05T15:41:42Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-3615-by-eLBati-bump-nobump, awaiting test results.

Signed-off-by eLBati

OCA-git-bot · 2023-10-05T16:06:39Z

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-3615-by-eLBati-bump-nobump, awaiting test results.

Signed-off-by eLBati

OCA-git-bot · 2023-10-05T16:31:10Z

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-3615-by-eLBati-bump-nobump, awaiting test results.

OCA-git-bot · 2023-10-05T16:55:34Z

Congratulations, your PR was merged at 0acf4cf. Thanks a lot for contributing to OCA. ❤️

eLBati and others added 30 commits September 28, 2023 09:47

[ADD] l10n_it_ricevute_bancarie

e5dafe0

moving from https://code.launchpad.net/~openobject-italia-core-devs/openobject-italia/l10n_it_ricevute_bancarie

[IMP] l10n_it_ricevute_bancarie splitted in l10n_it_ricevute_bancarie…

7940eab

…_jasper

[FIX] classe riba_distinta_move_line e context_today sconosciuto in 6\.0

0ea4f2c

[FIX] Reverted to previous revision.

27d3ce8

Changes for 6.0 should be done in a branch for 6.0. For the reason to use 'fields.date' instead of 'time', see https://bugs.launchpad.net/openobject-server/+bug/925361 https://bugs.launchpad.net/openerp-web/+bug/918257

[FIX] removing useless rows

51e5485

[IMP] copyright

71fd81d

[REM] l10n_it_ricevute_bancarie*

dd41178

[ADD] riba v7

5ea691f

Inserito fix richiesto da eLBati

57aadbc

[FIX] https://code.launchpad.net/~openobject-italia-core-devs/openobj…

6d42fa0

…ect-italia/adding_riba_v7/+merge/194620/comments/449412

[FIX] AttributeError: 'cursor' object has no attribute 'pool'

7476166

and valueerror

[IMP] PEP8

1f2c138

[FIX] osv.osv

3c19e60

[IMP] PEP8

4970699

[IMP] PEP8

23e0767

[REM] reverting PEP8 improvements.

7624534

Moving to lp:~agilebg/openobject-italia/riba_v7_style

[imp] l10n_it_ricevute_bancarie\: controllo presenza banca cliente in…

98837e1

… wizard export riba

[fix] l10n_it_ricevute_bancarie: lunghezza città banca max 23 caratte…

4b23d85

…ri in wizard export

[imp][l10n_it_ricevute_bancarie] controllo presenza su conto accettaz…

9cc0e84

…ione, data di registrazione su distinta

[REF] Set all the modules of the master branches to "installable": False

11dc5f8

moves all modules into a __unported__ directory

[MOV] move addons out of __unported__ (they remain not installable)

56664d8

[MIG] Make modules uninstallable

ce5fe12

[MIG] Rename manifest files

ff0c090

copying l10n_it_ricevute_bancarie from 8.0 branch

b798900

'Technical method to migrate a module from "8.0" to "10.0" branch' gives too many conflicts

FIX l10n_it_ricevute_bancarie: clean up files

af9e0e0

porting to new API porting to new accounting porting views porting tests FIX l10n_it_ricevute_bancarie wrong computation of payment_ids and tests ADD OCA dep for account_due_list

[IMP] l10n_it_ricevute_bancarie: add 'Sale Journals' filter and set i…

be2e9b2

…t as default for action_riba_da_emettere

FIX l10n_it_ricevute_bancarie

e8b73c4

debit bank is not mandatory in CBI file From documentation: 2.7 Struttura del record - codice fisso “40” 71-120 f an Banca/sportello domiciliataria F eventuale denominazione in chiaro della banca/sportello domiciliataria/o;

[8.0] evita di riaprire fattura se presente una ricevuta bancaria (OC…

2fc2162

…A#321)

FIX l10n_it_ricevute_bancarie

b35913b

File "odoo/lib/python2.7/site-packages/odoo/models.py", line 4369, in <lambda> @api.returns('self', lambda value: value.id) AttributeError: 'NoneType' object has no attribute 'id' while duplicating

SirAionTech marked this pull request as draft October 3, 2023 15:18

SirAionTech force-pushed the 16.0-mig-l10n_it_ricevute_bancarie branch from e12f143 to a5effa4 Compare October 3, 2023 15:32

SirAionTech marked this pull request as ready for review October 3, 2023 15:33

TonyMasciI suggested changes Oct 5, 2023

View reviewed changes

SirAionTech and others added 2 commits October 5, 2023 10:45

[MIG] l10n_it_ricevute_bancarie: Migration to 16.0

32367d7

Migration scripts not tested because `account` module cannot be migrated yet with OpenUpgrade Co-authored-by: Tony Masci <45100916+TonyMasciI@users.noreply.github.com>

[REF] l10n_it_riba: Use translations placeholders

5a5e002

Cleanup old syntax super(Class, instance) -> super() Remove unused code

SirAionTech force-pushed the 16.0-mig-l10n_it_ricevute_bancarie branch from a5effa4 to 5a5e002 Compare October 5, 2023 08:45

SirAionTech requested a review from TonyMasciI October 5, 2023 08:47

TonyMasciI approved these changes Oct 5, 2023

View reviewed changes

OpenCode added needs functional review 16.0 labels Oct 5, 2023

andreampiovesana approved these changes Oct 5, 2023

View reviewed changes

OCA-git-bot added the approved label Oct 5, 2023

OCA-git-bot added the bot is merging ⏳ label Oct 5, 2023

OCA-git-bot added a commit that referenced this pull request Oct 5, 2023

Merge PR #3615 into 16.0

1e414ea

Signed-off-by eLBati

OCA-git-bot added a commit that referenced this pull request Oct 5, 2023

Merge PR #3615 into 16.0

af456b5

Signed-off-by eLBati

OCA-git-bot merged commit e6d223a into OCA:16.0 Oct 5, 2023
5 of 6 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 5, 2023

odooNextev mentioned this pull request Nov 7, 2023

[MIG] l10n_it_ricevute_bancarie: Rename to l10n_it_riba OCA/OpenUpgrade#4218

Merged

SirAionTech mentioned this pull request Dec 19, 2023

Spostare menu RiBa in modo da renderlo visibile anche nella versione Enterprise #2526

Closed

3 tasks

francesco-ooops linked an issue Dec 20, 2023 that may be closed by this pull request

Metodo inutilizzato per le ricevute bancarie #3616

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] l10n_it_ricevute_bancarie -> l10n_it_riba #3615

[MIG] l10n_it_ricevute_bancarie -> l10n_it_riba #3615

SirAionTech commented Sep 28, 2023 •

edited

Loading

TonyMasciI Oct 5, 2023

SirAionTech Oct 5, 2023

TonyMasciI Oct 5, 2023

SirAionTech Oct 5, 2023

andreampiovesana left a comment •

edited

Loading

eLBati commented Oct 5, 2023

OCA-git-bot commented Oct 5, 2023

OCA-git-bot commented Oct 5, 2023

OCA-git-bot commented Oct 5, 2023

OCA-git-bot commented Oct 5, 2023

[MIG] l10n_it_ricevute_bancarie -> l10n_it_riba #3615

[MIG] l10n_it_ricevute_bancarie -> l10n_it_riba #3615

Conversation

SirAionTech commented Sep 28, 2023 • edited Loading

TonyMasciI Oct 5, 2023

Choose a reason for hiding this comment

SirAionTech Oct 5, 2023

Choose a reason for hiding this comment

TonyMasciI Oct 5, 2023

Choose a reason for hiding this comment

SirAionTech Oct 5, 2023

Choose a reason for hiding this comment

andreampiovesana left a comment • edited Loading

Choose a reason for hiding this comment

eLBati commented Oct 5, 2023

OCA-git-bot commented Oct 5, 2023

OCA-git-bot commented Oct 5, 2023

OCA-git-bot commented Oct 5, 2023

OCA-git-bot commented Oct 5, 2023

SirAionTech commented Sep 28, 2023 •

edited

Loading

andreampiovesana left a comment •

edited

Loading